Hi.
I have been trying to apply Linaro's HMP scheduler to a big.LITTLE
machine, which has 4 big and 4 LITTLE cores.
However, I could only utilize two cores with the HMP scheduler.
While hmp_select_faster_cpu() always selects the first core in the big
cluster and hmp_select_slower_cpu() always se
On 07/05/2011 11:30 PM, Per Forlin wrote:
Documentation about the background and the design of mmc non-blocking.
Host driver guidelines to minimize request preparation overhead.
I'd like to make a couple suggestions on the documentation when
documenting actual function names. In general, really
On 07/10/2011 12:21 PM, Per Forlin wrote:
Documentation about the background and the design of mmc non-blocking.
Host driver guidelines to minimize request preparation overhead.
Signed-off-by: Per Forlin
Acked-by: Randy Dunlap
---
ChangeLog:
v2: - Minor updates after proofreading comments from
+ and to test how the mmc host driver handles retries from
+ the block device.
+
config FAULT_INJECTION_DEBUG_FS
bool "Debugfs entries for fault-injection capabilities"
depends on FAULT_INJECTION&& SYSFS&& DEBUG_FS
--
J (James/Jay) Freyensee
Storage Technology Group
Intel Corporation
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
CONFIG_FAULT_INJECTION_DEBUG_FS
@@ -311,5 +312,6 @@ fail:
cleanup_fault_attr_dentries(attr);
return -ENOMEM;
}
+EXPORT_SYMBOL(init_fault_attr_dentries);
and here too?
#endif /* CONFIG_FAULT_INJECTION_DEBUG_FS */
--
J (James/Jay) Freyensee
Storage Technology Group
Intel
On Wednesday, March 21, 2012, Amit Kucheria wrote:
> On Wed, Mar 21, 2012 at 12:48 AM, Kevin Hilman wrote:
> > Arnd Bergmann writes:
> >
> >> On Tuesday 20 March 2012, Robert Lee wrote:
> >>> This patch series moves various functionality duplicated in platform
> >>> cpuidle drivers to the core cp
dle and acpi.
>
> This patch is intended to remove this dependency by using the
> notifier of intel_idle. This patch has the benefit of
> encapsulating the intel_idle driver and remove some exported
> functions.
>
> Signed-off-by: Daniel Lezcano
This one looks good to me too.
On Friday, June 29, 2012, Daniel Lezcano wrote:
> On 06/28/2012 09:24 PM, Rafael J. Wysocki wrote:
> > On Thursday, June 28, 2012, Daniel Lezcano wrote:
> >> When the system is booted with some cpus offline, the idle
> >> driver is not initialized. When a cpu is set onli
Hi,
On Monday, June 25, 2012, Daniel Lezcano wrote:
>
> Hi Stephen,
>
> we discussed last week to put in place a tree grouping the cpuidle
> modifications [1]. Is it possible to add the tree ?
>
> git://git.linaro.org/people/dlezcano/cpuidle-next.git #cpuidle-next
>
> It contains for the momen
On Monday, July 02, 2012, Daniel Lezcano wrote:
>
> On 07/02/2012 11:09 AM, Linus Walleij wrote:
> > On Mon, Jun 25, 2012 at 3:27 PM, Daniel Lezcano
> > wrote:
> >
> >> we discussed last week to put in place a tree grouping the cpuidle
> >> modifications [1]. Is it possible to add the tree ?
> >
On Tuesday, July 03, 2012, Daniel Lezcano wrote:
> On 07/02/2012 09:49 PM, Rafael J. Wysocki wrote:
> > On Monday, July 02, 2012, Daniel Lezcano wrote:
> >>
> >> On 07/02/2012 11:09 AM, Linus Walleij wrote:
> >>> On Mon, Jun 25, 2012 at 3:27 PM, Danie
On Tuesday, July 03, 2012, Daniel Lezcano wrote:
> On 07/03/2012 03:19 PM, Stephen Rothwell wrote:
> > Hi Daniel,
> >
> > On Tue, 03 Jul 2012 14:56:58 +0200 Daniel Lezcano
> > wrote:
> >>
> >>> So do you have a branch in the cpuidle-next.git tree that isn't going to
> >>> be rebased?
> >>
> >> N
On Tuesday, July 03, 2012, Linus Walleij wrote:
> On Tue, Jul 3, 2012 at 12:14 AM, Daniel Lezcano
> wrote:
>
> > If that makes sense to add myself to the MAINTAINER file as a
> > co-maintainer (understand: send to me also the patches, so I can take
> > care of them if Len does not respond), I am
On Thursday, July 05, 2012, Daniel Lezcano wrote:
> The 'enter_dead' function is only used for processor_idle.c
> and the same function is used several times. We fall into the
> same abuse with the multiple callbacks for the same function.
This isn't abuse, mind you. This is a normal practice.
>
On Thursday, July 05, 2012, Daniel Lezcano wrote:
> Move this specific flag to the header file.
The patch evidently does more than that.
Is it just a cleanup, or is there a functional reason for doing it?
Rafael
> Signed-off-by: Daniel Lezcano
> ---
> drivers/idle/intel_idle.c |8 ---
On Thursday, July 05, 2012, Daniel Lezcano wrote:
> We have the state index passed as parameter to the 'enter' function.
> Most of the drivers assign their 'enter' functions several times in
> the cpuidle_state structure, as we have the index, we can delegate
> to the driver to handle their own cal
dle and acpi.
>
> This patch is intended to remove this dependency by using the
> notifier of intel_idle. This patch has the benefit of
> encapsulating the intel_idle driver and remove some exported
> functions.
>
> Signed-off-by: Daniel Lezcano
> Acked-by: Srivatsa S. Bhat
On Friday, July 06, 2012, Daniel Lezcano wrote:
> On 07/05/2012 10:38 PM, Rafael J. Wysocki wrote:
> > On Thursday, July 05, 2012, Daniel Lezcano wrote:
> >> We have the state index passed as parameter to the 'enter' function.
> >> Most of the drivers assign
On Friday, July 06, 2012, Daniel Lezcano wrote:
> On 07/05/2012 10:43 PM, Rafael J. Wysocki wrote:
> > On Thursday, July 05, 2012, Daniel Lezcano wrote:
> >> Move this specific flag to the header file.
> >
> > The patch evidently does more than that.
> >
>
On Friday, July 06, 2012, Daniel Lezcano wrote:
> On 07/05/2012 10:40 PM, Rafael J. Wysocki wrote:
> > On Thursday, July 05, 2012, Daniel Lezcano wrote:
> >> The 'enter_dead' function is only used for processor_idle.c
> >> and the same function is used seve
On Friday, August 31, 2012, Daniel Lezcano wrote:
> On 07/24/2012 11:06 PM, Konrad Rzeszutek Wilk wrote:
> > On Tue, Jul 24, 2012 at 11:12:29PM +0200, Daniel Lezcano wrote:
> >> Remove the power field as it is not used.
> >>
> >> Signed-off-by: Daniel Lezcano
> >> Cc: Konrad Rzeszutek Wilk
> > Ac
On Saturday, September 01, 2012, Rafael J. Wysocki wrote:
> On Friday, August 31, 2012, Daniel Lezcano wrote:
> > On 07/24/2012 11:06 PM, Konrad Rzeszutek Wilk wrote:
> > > On Tue, Jul 24, 2012 at 11:12:29PM +0200, Daniel Lezcano wrote:
> > >> Remove the
On Thursday, September 06, 2012, Daniel Lezcano wrote:
> On 09/06/2012 10:04 PM, Rafael J. Wysocki wrote:
> > On Thursday, September 06, 2012, Daniel Lezcano wrote:
> >> On 09/06/2012 09:54 AM, Daniel Lezcano wrote:
> >>> On 09/05/2012 03:41 PM, Rafael J. Wys
On Thursday, September 06, 2012, Daniel Lezcano wrote:
> On 09/06/2012 09:54 AM, Daniel Lezcano wrote:
> > On 09/05/2012 03:41 PM, Rafael J. Wysocki wrote:
> >> On Saturday, September 01, 2012, Rafael J. Wysocki wrote:
> >>> On Friday, August 31, 2012, Daniel Lezcano
On Friday, September 07, 2012, Rafael J. Wysocki wrote:
> On Friday, September 07, 2012, Rafael J. Wysocki wrote:
> > On Friday, September 07, 2012, Daniel Lezcano wrote:
> > > Currently we have the cpuidle_device field in the acpi_processor_power
> > > structure.
>
On Friday, September 07, 2012, Daniel Lezcano wrote:
> Since commit 46bcfad7a819bd17ac4e831b04405152d59784ab,
> cpuidle: Single/Global registration of idle states
>
> we have a single registration for the cpuidle states which makes
> sense. But now two new architectures are coming: tegra3
On Friday, September 07, 2012, Daniel Lezcano wrote:
> Currently we have the cpuidle_device field in the acpi_processor_power
> structure.
> This adds a dependency in processor.h for cpuidle.h.
>
> In order to be consistent with the rest of the drivers and for the per cpu
> states
> coming right
On Friday, September 07, 2012, Daniel Lezcano wrote:
> The cpuidle core takes care of filling this field from drv->state_count.
I'm not quite sure this is always valid. If dev has already been
initialized and dev->state_count is different from 0,
cpuidle_enable_device() doesn't actually change it
On Friday, September 07, 2012, Daniel Lezcano wrote:
> This variable is only used in the in processor_driver.c.
> This patch reduces the scope of the variable by moving it
> to this file.
Well, the changelog is wrong (because the scope of the variable is
not reduced by moving it out of the header)
On Friday, September 07, 2012, Rafael J. Wysocki wrote:
> On Friday, September 07, 2012, Daniel Lezcano wrote:
> > Currently we have the cpuidle_device field in the acpi_processor_power
> > structure.
> > This adds a dependency in processor.h for cpuidle.h.
> >
> &g
On Monday, September 03, 2012, Rajagopal Venkat wrote:
> Prepare devfreq core framework to support devices which
> can idle. When device idleness is detected perhaps through
> runtime-pm, need some mechanism to suspend devfreq load
> monitoring and resume back when device is online. Present
> code
On Monday, September 03, 2012, Rajagopal Venkat wrote:
> Add devfreq suspend/resume apis for devfreq users. This patch
> supports suspend and resume of devfreq load monitoring, required
> for devices which can idle.
>
> Signed-off-by: Rajagopal Venkat
I'd call the new functions devfreq_dev_suspe
On Monday, September 03, 2012, Rajagopal Venkat wrote:
> Devfreq returns governor predicted frequency as current
> frequency via sysfs interface. But device may not support
> all frequencies that governor predicts.
Do you have any examples, even out of the tree?
> Its driver
> responsibility to m
On Monday, September 10, 2012, Rajagopal Venkat wrote:
> On 10 September 2012 03:16, Rafael J. Wysocki wrote:
> > On Monday, September 03, 2012, Rajagopal Venkat wrote:
> >> Prepare devfreq core framework to support devices which
> >> can idle. When device idleness
On Tuesday, September 11, 2012, Daniel Lezcano wrote:
> On 09/07/2012 11:19 PM, Rafael J. Wysocki wrote:
> > On Friday, September 07, 2012, Daniel Lezcano wrote:
> >> This variable is only used in the in processor_driver.c.
> >> This patch reduces the scope of the va
On Tuesday, September 11, 2012, Daniel Lezcano wrote:
> On 09/08/2012 12:06 AM, Rafael J. Wysocki wrote:
> > On Friday, September 07, 2012, Rafael J. Wysocki wrote:
> >> On Friday, September 07, 2012, Rafael J. Wysocki wrote:
> >>> On Friday, September
On Friday, September 14, 2012, Daniel Lezcano wrote:
> Currently we have the cpuidle_device field in the acpi_processor_power
> structure.
> This adds a dependency between processor.h and cpuidle.h
>
> Although it is not a real problem, removing this dependency has the benefit of
> separating a b
On Friday, September 14, 2012, Daniel Lezcano wrote:
> The 'errata' variable is a global variable which is set to zero,
> no need to do that with a memset in the init function.
>
> Signed-off-by: Daniel Lezcano
Applied to the linux-next branch of the linux-pm.git tree as v3.7 material.
Thanks,
On Friday, September 14, 2012, Daniel Lezcano wrote:
> The 'device' parameter is not used neither in acpi_processor_power_init
> and acpi_processor_power_exit. This patch removes it.
>
> Signed-off-by: Daniel Lezcano
Applied to the linux-next branch of the linux-pm.git tree as v3.7 material.
Th
On Sunday, September 16, 2012, Daniel Lezcano wrote:
> On 09/07/2012 11:50 PM, Rafael J. Wysocki wrote:
> > On Friday, September 07, 2012, Daniel Lezcano wrote:
> >> The cpuidle core takes care of filling this field from drv->state_count.
> >
> > I'm not qu
On Monday, September 17, 2012, MyungJoo Ham wrote:
> > From: Rajagopal Venkat
> >
> > Devfreq returns governor predicted frequency as current frequency
> > via sysfs interface. But device may not support all frequencies
> > that governor predicts. So add a callback in device profile to get
> > cu
On Monday, September 17, 2012, Daniel Lezcano wrote:
> On 09/08/2012 12:17 AM, Rafael J. Wysocki wrote:
> > On Friday, September 07, 2012, Daniel Lezcano wrote:
> >> Since commit 46bcfad7a819bd17ac4e831b04405152d59784ab,
> >> cpuidle: Single/Global registration
On Monday, September 17, 2012, Daniel Lezcano wrote:
> On 09/17/2012 10:50 PM, Rafael J. Wysocki wrote:
> > On Monday, September 17, 2012, Daniel Lezcano wrote:
> >> On 09/08/2012 12:17 AM, Rafael J. Wysocki wrote:
> >>> On Friday, September 07, 2012, Daniel Lezc
On Tuesday, September 18, 2012, Lorenzo Pieralisi wrote:
> On Mon, Sep 17, 2012 at 10:35:00PM +0100, Daniel Lezcano wrote:
> > On 09/17/2012 10:50 PM, Rafael J. Wysocki wrote:
> > > On Monday, September 17, 2012, Daniel Lezcano wrote:
> > >> On 09/08/2012 12:
On Wednesday, September 19, 2012, Daniel Lezcano wrote:
> These two functions are never used.
This is not the case. pm_genpd_attach_cpuidle() and
pm_genpd_detach_cpuidle() use them.
Please be more careful.
Thanks,
Rafael
> Signed-off-by: Daniel Lezcano
> ---
> drivers/cpuidle/driver.c | 2
On Wednesday, September 19, 2012, Daniel Lezcano wrote:
> Clarify the purpose of the function by changing its name and
> move the condition out of this function.
Why exactly are you removing the condition?
Rafael
> Signed-off-by: Daniel Lezcano
> ---
> drivers/cpuidle/driver.c | 15
On Wednesday, September 19, 2012, Daniel Lezcano wrote:
> This mindless patch is just about removing some trailing
> carriage returns.
>
> Signed-off-by: Daniel Lezcano
Applied.
Thanks,
Rafael
> ---
> drivers/cpuidle/driver.c |3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
On Thursday, September 20, 2012, Daniel Lezcano wrote:
> The function __cpuidle_register_driver name is confusing because it
> suggests, conforming to the coding style of the kernel, it registers
> the driver without taking a lock. Actually, it just fill the different
> power field states with a de
On Saturday, September 29, 2012, Daniel Lezcano wrote:
> On 09/29/2012 11:41 AM, Francesco Lavra wrote:
> > Hi,
>
> Hi Francesco,
>
> thanks for reviewing the patch.
>
> >> static ssize_t show_current_driver(struct device *dev,
> >> struct device_attribute *attr,
>
On Monday 01 of October 2012 15:42:39 Vincent Guittot wrote:
> Hi Rafael,
>
> Ping.
I'm considering this for v3.8, but I'd like Paul (CCed) to tell me what he
thinks about it.
Thanks,
Rafael
> On 25 September 2012 15:42, Vincent Guittot
> wrote:
> > synchronize_rcu blocks the caller of opp_e
On Monday 01 of October 2012 15:42:39 Vincent Guittot wrote:
> Hi Rafael,
>
> Ping.
I'm considering this for v3.8, but I'd like Paul (CCed) to tell me what he
thinks about it.
Thanks,
Rafael
> On 25 September 2012 15:42, Vincent Guittot
> wrote:
> > synchronize_rcu blocks the caller of opp_e
On Sunday 30 of September 2012 18:34:31 Daniel Lezcano wrote:
> On 09/30/2012 12:07 AM, Rafael J. Wysocki wrote:
> > On Saturday, September 29, 2012, Daniel Lezcano wrote:
> >> On 09/29/2012 11:41 AM, Francesco Lavra wrote:
> >>> Hi,
> >> Hi Francesco,
&
On Tuesday 02 of October 2012 14:27:17 Daniel Lezcano wrote:
> On 10/02/2012 04:08 AM, Rafael J. Wysocki wrote:
> > On Sunday 30 of September 2012 18:34:31 Daniel Lezcano wrote:
> >> On 09/30/2012 12:07 AM, Rafael J. Wysocki wrote:
> >>> On Saturday, September
t > 0))
> cpuidle_curr_driver = NULL;
> -
> +out:
> spin_unlock(&cpuidle_driver_lock);
> }
> EXPORT_SYMBOL_GPL(cpuidle_unregister_driver);
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
> Sounds like a reasonable idea.
>
> > and the content of the file:
> >
> > /sys/devices/system/cpu/cpuidle/current_driver will show the driver
> > associated with current cpu ?
> >
>
> I think that's ok.
Yes, that sounds good.
Thanks,
Rafae
j)
> goto error_state;
> @@ -374,7 +399,8 @@ int cpuidle_add_state_sysfs(struct cpuidle_device *device)
> kobj->state_usage = &device->states_usage[i];
> init_completion(&kobj->kobj_unregister);
>
> - ret = kobject_init_and_add(&kobj->kobj, &ktype_state_cpuidle,
> &device->kobj,
> + ret = kobject_init_and_add(&kobj->kobj,
> +&ktype_state_cpuidle, &device->kobj,
> "state%d", i);
> if (ret) {
> kfree(kobj);
> diff --git a/include/linux/cpuidle.h b/include/linux/cpuidle.h
> index a4ff9f8..0e0b0ad 100644
> --- a/include/linux/cpuidle.h
> +++ b/include/linux/cpuidle.h
> @@ -164,6 +164,13 @@ extern int cpuidle_wrap_enter(struct cpuidle_device *dev,
> struct cpuidle_driver *drv, int index));
> extern int cpuidle_play_dead(void);
>
> +extern int cpuidle_for_each_driver(
> + int (*cb)(int, struct cpuidle_driver *, void *), void *data);
> +
> +extern struct cpuidle_driver *cpuidle_get_cpu_driver(int cpu);
> +extern int cpuidle_register_cpu_driver(struct cpuidle_driver *drv, int cpu);
> +extern void cpuidle_unregister_cpu_driver(struct cpuidle_driver *drv, int
> cpu);
> +
> #else
> static inline void disable_cpuidle(void) { }
> static inline int cpuidle_idle_call(void) { return -ENODEV; }
> @@ -190,7 +197,6 @@ static inline int cpuidle_wrap_enter(struct
> cpuidle_device *dev,
> struct cpuidle_driver *drv, int index))
> { return -ENODEV; }
> static inline int cpuidle_play_dead(void) {return -ENODEV; }
> -
> #endif
>
> #ifdef CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED
>
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
> }
>
> +static int devfreq_suspend_device(struct devfreq *devfreq)
> +{
> + return 0;
> +}
> +
> +static int devfreq_resume_device(struct devfreq *devfreq)
> +{
> + return 0;
> +}
> +
> static struct opp *devfreq_recommended_opp(struct device *dev,
> unsigned long *freq, u32 flags)
> {
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
ivers/devfreq/governor.h| 11 +
> >> drivers/devfreq/governor_performance.c| 16 +-
> >> drivers/devfreq/governor_powersave.c | 16 +-
> >> drivers/devfreq/governor_simpleondemand.c | 24 ++
> >> drivers/devfreq/governor_userspace.c
On Thursday 11 of October 2012 12:04:37 Daniel Lezcano wrote:
> On 10/07/2012 11:26 PM, Rafael J. Wysocki wrote:
> > On Tuesday 25 of September 2012 00:43:54 Daniel Lezcano wrote:
> >> With the tegra3 and the big.LITTLE [1] new architectures, several cpus
> >> wit
On Wednesday 03 of October 2012 21:38:09 Vincent Guittot wrote:
> On Wednesday, 3 October 2012, Paul E. McKenney
> wrote:
> > On Tue, Oct 02, 2012 at 04:02:05AM +0200, Rafael J. Wysocki wrote:
> >> On Monday 01 of October 2012 15:42:39 Vincent Guittot wrote:
> >> &
; static ssize_t show_bios_limit(struct cpufreq_policy *policy, char *buf)
> {
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
+= sprintf(&buf[i], "\n");
> diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> index b60f6ba..fc4b785 100644
> --- a/include/linux/cpufreq.h
> +++ b/include/linux/cpufreq.h
> @@ -22,6 +22,8 @@
> #include
>
> #define CPUFREQ_NAME_LEN 16
>
On Monday 08 of October 2012 10:48:24 MyungJoo Ham wrote:
> > On 8 October 2012 03:31, Rafael J. Wysocki wrote:
> > > On Thursday 04 of October 2012 14:58:33 Rajagopal Venkat wrote:
> > >> Add devfreq suspend/resume apis for devfreq users. This patch
> > >>
On Tuesday 16 of October 2012 09:09:15 Viresh Kumar wrote:
> On 15 October 2012 23:21, Rafael J. Wysocki wrote:
> > On Wednesday 10 of October 2012 10:12:11 Viresh Kumar wrote:
> >> Arrays for governer and driver name are of size CPUFREQ_NAME_LEN or 16.
> >> i.e.
On Tuesday 16 of October 2012 06:40:19 MyungJoo Ham wrote:
> > On Monday 08 of October 2012 10:48:24 MyungJoo Ham wrote:
> > > > On 8 October 2012 03:31, Rafael J. Wysocki wrote:
> > > > > On Thursday 04 of October 2012 14:58:33 Rajagopal Venkat wrote:
> >
puidle");
> if (!error)
> @@ -426,11 +424,7 @@ int cpuidle_add_sysfs(struct device *cpu_dev)
> * cpuidle_remove_sysfs - deletes a sysfs instance on the target device
> * @dev: the target device
> */
> -void cpuidle_remove_sysfs(struct device *cpu_dev)
> +void cpuidle_remove_sysfs(struct cpuidle_device *dev)
> {
> - int cpu = cpu_dev->id;
> - struct cpuidle_device *dev;
> -
> - dev = per_cpu(cpuidle_devices, cpu);
> kobject_put(&dev->kobj);
> }
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
te;
> @@ -413,6 +413,8 @@ int cpuidle_add_sysfs(struct cpuidle_device *dev)
> struct device *cpu_dev = get_cpu_device((unsigned long)dev->cpu);
> int error;
>
> + init_completion(&dev->kobj_unregister);
> +
> error = kobject_init_and_add(&dev->kobj, &ktype_cpuidle, &am
cpuidle_device *device)
> +{
> + return cpuidle_add_state_sysfs(device);
> +}
> +
> +/**
> + * cpuidle_remove_device_sysfs : removes device specific sysfs attributes
> + * @device : the target device
> + */
> +void cpuidle_remove_device_sysfs(struct cpuidle_device *device)
> +{
>
t; -
> struct cpuidle_device {
> unsigned intregistered:1;
> unsigned intenabled:1;
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
icy = cpufreq_cpu_get(policy->cpu);
> if (!policy)
> return -EINVAL;
>
> - if (cpu_online(cpu) && cpufreq_driver->getavg)
> - ret = cpufreq_driver->getavg(policy, cpu);
> + ret = cpufreq_driver->getavg(policy, cpu);
f71 viresh kumar 2012-10-23 50return idle_time;
> > 83a73f71 viresh kumar 2012-10-23 51 }
> > 83a73f71 viresh kumar 2012-10-23 52 EXPORT_SYMBOL_GPL(get_cpu_idle_time);
> >
> > ---
> > 0-DAY kernel build testing backend Open Source Technology Center
&
> For everybody else, this patch is already pushed by Rafael in his linux-next
> branch.
Well, not yet, although I'm going to do that.
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
On Wednesday 24 of October 2012 21:43:46 Rafael J. Wysocki wrote:
> On Wednesday 24 of October 2012 11:37:13 Viresh Kumar wrote:
> > On 22 October 2012 14:16, Viresh Kumar wrote:
> > > On 20 October 2012 01:42, Viresh Kumar wrote:
> > >> Initially ondemand governor
t_cpu_idle_time_us(cpu, NULL);
>
> @@ -81,7 +81,7 @@ void dbs_check_cpu(struct dbs_data *dbs_data, int cpu)
> /* Get Absolute Load (in terms of freq for ondemand gov) */
> for_each_cpu(j, policy->cpus) {
> struct cpu_dbs_common_info *j_cdbs;
> -
drivers/cpufreq/cpufreq_userspace.c
> +++ b/drivers/cpufreq/cpufreq_userspace.c
> @@ -11,6 +11,8 @@
> *
> */
>
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
> #include
> #include
> #include
> diff --git a/drivers/cpufreq/freq_table.c b/drivers/cp
On Saturday 20 of October 2012 10:12:07 Viresh Kumar wrote:
> On Oct 20, 2012 3:37 AM, "Rafael J. Wysocki" wrote:
> >
> > On Saturday 20 of October 2012 01:42:05 Viresh Kumar wrote:
> > > There is no need to do cpufreq_get_cpu() and cpufreq_put_cpu() for
> dr
ested on ARM Dual Cortex-A9 U8500 (aka Snowball)
> >
> > V1 tested on Tegra3 and Vexpress TC2
> >
>
> V2 tested on Tegra3.
Do I assume correctly that Tested-by applies?
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
AD 1 /* 1us */
> -#define PM_TIMER_TICKS_TO_US(p) (((p) *
> 1000)/(PM_TIMER_FREQUENCY/1000))
>
> static unsigned int max_cstate __read_mostly = ACPI_PROCESSOR_MAX_POWER;
> module_param(max_cstate, uint, );
>
--
I speak only for myself.
Rafael J.
t; -
> #include
> #include
> -#include
>
> #define PREFIX "ACPI: "
> ACPI_MODULE_NAME("processor_idle");
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
cx(pr);
> + acpi_processor_setup_cpuidle_cx(pr, dev);
>
> /* Register per-cpu cpuidle_device. Cpuidle driver
>* must already be registered before registering device
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
return retval;
> - }
> - acpi_processor_registered++;
> + acpi_processor_setup_cpuidle_cx(pr, dev);
> +
> + /* Register per-cpu cpuidle_device. Cpuidle driver
> + * must already be registered before registering device
> + */
> + retval = cpuidle_register_device(dev);
> + if (retval) {
> + if (acpi_processor_registered == 0)
> + cpuidle_unregister_driver(&acpi_idle_driver);
> + return retval;
> }
> +
> + acpi_processor_registered++;
> +
> return 0;
> }
>
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
On Thursday, October 25, 2012 09:00:22 AM Viresh Kumar wrote:
> On 25 October 2012 02:44, Rafael J. Wysocki wrote:
> > On Wednesday 24 of October 2012 13:15:58 Viresh Kumar wrote:
> >> There were few sparse warnings due to mismatch of type on function
> >> arguments.
&
On Thursday, October 25, 2012 08:59:11 AM Viresh Kumar wrote:
> On 25 October 2012 02:42, Rafael J. Wysocki wrote:
> > On Wednesday 24 of October 2012 21:43:46 Rafael J. Wysocki wrote:
> >> On Wednesday 24 of October 2012 11:37:13 Viresh Kumar wrote:
> >> > On 22 Oc
_online(policy->cpu) && cpufreq_driver->target)
> retval = cpufreq_driver->target(policy, target_freq, relation);
>
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
q);
> if (cpu_online(policy->cpu) && cpufreq_driver->target)
> retval = cpufreq_driver->target(policy, target_freq, relation);
>
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
On Friday, October 26, 2012 09:23:45 PM Daniel Lezcano wrote:
>
> Rafael,
>
> this patchset does not apply anymore on linux-pm-next.
>
> Let me refresh it and resend a V3.
OK, thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source
cy->min)
> + target_freq = policy->min;
> +
> + pr_debug("target for CPU %u: %u kHz, relation %u, requested %u kHz\n",
> + policy->cpu, target_freq, relation, old_target_freq);
>
> if (target_freq == policy->cur)
>
t; index ed87399..860a686 100644
> --- a/drivers/cpuidle/sysfs.c
> +++ b/drivers/cpuidle/sysfs.c
> @@ -12,6 +12,7 @@
> #include
> #include
> #include
> +#include
>
> #include "cpuidle.h"
>
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
On Friday, October 26, 2012 01:17:12 PM Rafael J. Wysocki wrote:
> On Friday, October 26, 2012 03:06:26 PM Viresh Kumar wrote:
> > Avoid calling cpufreq driver's target() routine if new frequency is same as
> > policies current frequency.
> >
> > Signed-off-by: Vir
le_state_usage *state_usage;
> - struct completion kobj_unregister;
> - struct kobject kobj;
> -};
> -
> struct cpuidle_device {
> unsigned intregistered:1;
> unsigned intenabled:1;
--
I speak only for myself.
Rafael J. Wysocki, Intel Open So
+--
> drivers/cpuidle/sysfs.c | 174 --
> include/linux/cpuidle.h |8 ++-
> 6 files changed, 388 insertions(+), 52 deletions(-)
All patches in the series applied to the linux-next branch of the linux-pm.git
tree a
ktime_t kt_before, kt_after;
> - s64 usec_delta;
> int cpu = smp_processor_id();
>
> cstate = (((eax) >> MWAIT_SUBSTATE_SIZE) & MWAIT_CSTATE_MASK) + 1;
> @@ -297,8 +295,6 @@ static int intel_idle(struct cpuidle_device *dev,
> if (!(lapic_timer_reli
r;
> - s64 usec_delta;
> int cpu = smp_processor_id();
>
> cstate = (((eax) >> MWAIT_SUBSTATE_SIZE) & MWAIT_CSTATE_MASK) + 1;
> @@ -297,8 +295,6 @@ static int intel_idle(struct cpuidle_device *dev,
> if (!(lapic_timer_reliable_states & (1 << (cstate
> clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ENTER, &cpu);
>
> - kt_before = ktime_get_real();
> -
> stop_critical_timings();
> if (!need_resched()) {
>
> @@ -310,17 +306,9 @@ static int intel_idle(struct cpuidle_device *dev,
>
> start_critical_timings();
>
> - kt_after = ktime_get_real();
> - usec_delta = ktime_to_us(ktime_sub(kt_after, kt_before));
> -
> - local_irq_enable();
> -
> if (!(lapic_timer_reliable_states & (1 << (cstate
> clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &cpu);
>
> - /* Update cpuidle counters */
> - dev->last_residency = (int)usec_delta;
> -
> return index;
> }
>
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
---
> > drivers/cpuidle/cpuidle.c| 17 -
> > drivers/cpuidle/driver.c | 25 -
> > drivers/cpuidle/governors/menu.c |8 ++--
> > include/linux/cpuidle.h |2 +-
> > 4 files changed, 7 insertions(+
data->last_state_idx = i;
> > data->exit_us = s->exit_latency;
> > break;
> > }
> > }
>
> Actually I was planning to do that in a separate patch.
Can you submit that second patch too, please, so that people don't h
e, which are online. We aren't
> + * managing offline cpus here.
> + */
> + cpumask_and(policy->cpus, policy->cpus, cpu_online_mask);
> +
> policy->user_policy.min = policy->min;
> policy->user_policy.max = policy->max;
>
&g
On Wednesday, January 02, 2013 11:59:57 AM Viresh Kumar wrote:
> On 16 December 2012 19:07, Viresh Kumar wrote:
> > On 16 December 2012 18:34, Rafael J. Wysocki wrote:
>
> >> Well, this series makes sense to me, but I'd like to hear what the other
> >> peo
On Thursday, January 03, 2013 09:02:22 AM Viresh Kumar wrote:
> On 3 January 2013 06:43, Rafael J. Wysocki wrote:
> >> BTW, i consider them as fixes and so would make sense to get them in next
> >> rc.
> >> What do you think?
> >
> > Yes, if somebody
On Friday, January 04, 2013 10:44:36 AM Viresh Kumar wrote:
> On 3 January 2013 17:32, Rafael J. Wysocki wrote:
> > True, but have those bugs been introduced recently (ie. in v3.8-rc1 or
> > later)?
>
> Don't know... I feel they were always there, its just that n
On Monday, January 07, 2013 11:56:36 PM Daniel Lezcano wrote:
> On 01/07/2013 10:58 PM, Rafael J. Wysocki wrote:
> > Hi,
> >
> > Thanks for the patch!
> >
> > I'd like Daniel to have a look at it still.
>
> I agree with this patch. I was about to send
1 - 100 of 133 matches
Mail list logo
