Re: [PATCH PM-QA] thermal/thermal_06.sh: add missing get_os before check the return value

2017-10-16 Thread Lisa Nguyen
Hi Li, On 13 October 2017 at 02:51, Li Zhijian wrote: > Signed-off-by: Li Zhijian Can you add a brief commit message to why this change is necessary and send an updated patch please? Thanks, Lisa > --- > thermal/thermal_06.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/thermal/t

[PATCH PM-QA v2] thermal/thermal_06.sh: add missing get_os before check the return value

2017-10-16 Thread Li Zhijian
'ps' have different output between Android and ubuntu, and test suite use get_os to determine which OS the scripts are running on. at commit 84479a38, thermal: Get correct PID for heat_cpu based on OS this patch want to get PID based on OS, but it looks thermal_06.sh foget to add get_os before che

[PATCH PM-QA] functions: correct get_os logic

2017-10-16 Thread Li Zhijian
at commit aea49c3: functions: Fix logic for get_os() function To determine which OS the scripts are running on, check if the build.prop file exists instead of using the lsb_release command. If it does, then the scripts are running on Android; otherwise it's Ubuntu. From the changelog, we can k