Re: [PATCH POWERTOP] Remove temporary file created during calibration

2014-07-01 Thread Amit Kucheria
Mohammad, This fix should go upstream. cc'ing the powertop list. Regards, Amit On Thu, Jun 26, 2014 at 12:27 PM, Mohammad Merajul Islam Molla wrote: > powertop creates temporary file in /tmp folder during calibration. > Simply closing does not remove these files. > Instead use unlink to remove

Re: [PATCH POWERTOP] Fix various resource leaks

2014-07-01 Thread Amit Kucheria
Mohammad, This fix should go upstream. cc'ing the powertop list. Regards, Amit On Thu, Jun 26, 2014 at 12:42 PM, Mohammad Merajul Islam Molla wrote: > Fixes some resource leaks detected by valgrind and coverity scan. > > > diff --git a/src/devices/ahci.cpp b/src/devices/ahci.cpp > index ac06460

Re: [PATCH v2] pm-qa/cpuhotplug: Run cpuhotplug on all cpus

2014-07-01 Thread Lisa Nguyen
Hi Amit, On 30 June 2014 22:43, Amit Kucheria wrote: > Some nits below: > > On Tue, Jul 1, 2014 at 5:35 AM, Lisa Nguyen wrote: >> Run the cpuhotplug test suite on all cpus including cpu0. If we wish >> to skip cpu0, pass the parameter, hotplug_allow_cpu0=1, to make check >> like in these example