Re: [PATH v3 0/2] Add v4l2 subdev driver for S5K4ECGX sensor with embedded SoC ISP

2012-08-04 Thread Sylwester Nawrocki
Hi Sangwook, On 08/03/2012 04:24 PM, Sangwook Lee wrote: > Hi Sylwester > > Thank you for the review. > > On 2 August 2012 21:11, Sylwester Nawrocki > wrote: >> On 08/02/2012 03:42 PM, Sangwook Lee wrote: >>> The following 2 patches add driver for S5K4ECGX sensor with embedded ISP >>> SoC, >

Re: [PATH v3 1/2] v4l: Add factory register values form S5K4ECGX sensor

2012-08-04 Thread Sylwester Nawrocki
Hi Sangwook, On 08/03/2012 05:05 PM, Sangwook Lee wrote: >>> +/* configure 30 fps */ >>> +static const struct regval_list s5k4ecgx_fps_30[] = { >> >> It really depends on sensor master clock frequency (as specified >> in FIMC driver platform data) and PLL setting what the resulting >> frame rate w