Re: [U-Boot] [PATCH v4 1/2] ARMV7: Add support for Samsung ORIGEN board

2011-08-10 Thread Chander Kashyap
Hi Detlev, On 10 August 2011 15:48, Detlev Zundel wrote: > Hi Chander, > > [...] > > >>> lease get rid of all these magic hard coded constants. Use symbolic > >>> names instead. If needed, auto-generate these from the respective C > >>> structs. If needed, create the C structs. > >>> > >> > >

Re: [U-Boot] [PATCH v4 1/2] ARMV7: Add support for Samsung ORIGEN board

2011-08-10 Thread Detlev Zundel
Hi Chander, [...] >>> lease get rid of all these magic hard coded constants. Use symbolic >>> names instead. If needed, auto-generate these from the respective C >>> structs. If needed, create the C structs. >>> >> >> I will change hard coded values to symbolic names >> > > While doing this, I