Re: [RFC PATCH v4 1/4] cpuidle: Add time keeping and irq enabling

2012-02-06 Thread Rob Lee
Hello Colin, thanks for the review. On Sat, Feb 4, 2012 at 1:02 PM, Colin Cross wrote: > On Tue, Jan 31, 2012 at 7:00 PM, Robert Lee wrote: >> Make necessary changes to add implement time keepign and irq enabling > keeping >> in the core cpuidle code.  This will allow the remove of these >> func

Re: [RFC PATCH v4 1/4] cpuidle: Add time keeping and irq enabling

2012-02-06 Thread Rob Lee
On Sat, Feb 4, 2012 at 4:06 PM, Turquette, Mike wrote: > On Sat, Feb 4, 2012 at 11:02 AM, Colin Cross wrote: >> On Tue, Jan 31, 2012 at 7:00 PM, Robert Lee wrote: >>> Make necessary changes to add implement time keepign and irq enabling >> keeping >>> in the core cpuidle code.  This will allow t

Re: [RFC PATCH v4 1/4] cpuidle: Add time keeping and irq enabling

2012-02-05 Thread Colin Cross
On Sat, Feb 4, 2012 at 2:06 PM, Turquette, Mike wrote: > On Sat, Feb 4, 2012 at 11:02 AM, Colin Cross wrote: >> What's the point of the pre_enter call?  This seems very similar to >> the prepare call that was removed in 3.2.  Drivers can already demote > > Hi Colin, > > I asked Rob to re-introduc

Re: [RFC PATCH v4 1/4] cpuidle: Add time keeping and irq enabling

2012-02-04 Thread Turquette, Mike
On Sat, Feb 4, 2012 at 5:36 PM, Colin Cross wrote: > On Sat, Feb 4, 2012 at 2:06 PM, Turquette, Mike wrote: >> On Sat, Feb 4, 2012 at 11:02 AM, Colin Cross wrote: >>> What's the point of the pre_enter call?  This seems very similar to >>> the prepare call that was removed in 3.2.  Drivers can al

Re: [RFC PATCH v4 1/4] cpuidle: Add time keeping and irq enabling

2012-02-04 Thread Turquette, Mike
On Sat, Feb 4, 2012 at 11:02 AM, Colin Cross wrote: > On Tue, Jan 31, 2012 at 7:00 PM, Robert Lee wrote: >> Make necessary changes to add implement time keepign and irq enabling > keeping >> in the core cpuidle code.  This will allow the remove of these >> functionalities from the platform cpuidl

Re: [RFC PATCH v4 1/4] cpuidle: Add time keeping and irq enabling

2012-02-04 Thread Colin Cross
On Tue, Jan 31, 2012 at 7:00 PM, Robert Lee wrote: > Make necessary changes to add implement time keepign and irq enabling keeping > in the core cpuidle code.  This will allow the remove of these > functionalities from the platform cpuidle implementations. > > Signed-off-by: Robert Lee > --- >  d