Re: [PATCHv3] cpufreq for freescale mx51

2010-10-19 Thread Sascha Hauer
On Tue, Oct 19, 2010 at 05:28:51PM +0800, Yong Shen wrote: > > > > > > > > > +#include > > > + > > > +static struct cpu_op mx51_cpu_op[] = { > > > + { > > > + .cpu_rate = 16000,}, > > > + { > > > + .cpu_rate = 8,}, > > > +}; > > > > Why did you remove the values between

Re: [PATCHv3] cpufreq for freescale mx51

2010-10-19 Thread Yong Shen
Vishwanath, Thanks for suggestion. Voltage change is not a must for frequency change, and it can be integrate in after regulator driver is ready for mx51. Yong On Tue, Oct 19, 2010 at 5:18 PM, Vishwanath Sripathy < vishwanath.sripa...@linaro.org> wrote: > Yong, > > >On Mon, Oct 18, 2010 at 1:51

Re: [PATCHv3] cpufreq for freescale mx51

2010-10-19 Thread Yong Shen
> > > > > +#include > > + > > +static struct cpu_op mx51_cpu_op[] = { > > + { > > + .cpu_rate = 16000,}, > > + { > > + .cpu_rate = 8,}, > > +}; > > Why did you remove the values between 800MHz and 160MHz? 400MHz and > 200Mhz should work also, no? > > It proved that thos

Re: [PATCHv3] cpufreq for freescale mx51

2010-10-19 Thread Vishwanath Sripathy
Yong, >On Mon, Oct 18, 2010 at 1:51 PM, wrote: >From: Yong Shen >the operating points are tested on babbage 3.0 Commit log needs more description like What are the supported operating points, Is there any link between mpu OPP and other devices? What are the platforms this patch is tested agains

Re: [PATCHv3] cpufreq for freescale mx51

2010-10-19 Thread Yong Shen
Hi amit, On Mon, Oct 18, 2010 at 6:02 PM, Amit Kucheria wrote: > Yong, > > I get the following errors if I try to compile this with the Linaro > toolchain. > > In file included from > > /home/amit/work/sources/linux-amit-upstream.git/arch/arm/plat-mxc/include/mach/hardware.h:63:0, >

Re: [PATCHv3] cpufreq for freescale mx51

2010-10-18 Thread Sascha Hauer
On Mon, Oct 18, 2010 at 04:21:45PM +0800, yong.s...@linaro.org wrote: > From: Yong Shen > > the operating points are tested on babbage 3.0 > > Signed-off-by: Yong Shen > --- > arch/arm/Kconfig |6 + > arch/arm/mach-mx5/Kconfig |1 + > arch/arm/mach-mx

Re: [PATCHv3] cpufreq for freescale mx51

2010-10-18 Thread Amit Kucheria
Yong, I get the following errors if I try to compile this with the Linaro toolchain. In file included from /home/amit/work/sources/linux-amit-upstream.git/arch/arm/plat-mxc/include/mach/hardware.h:63:0, from /home/amit/work/sources/linux-amit-upstream.git/arch/a