Re: [PATCHv2] Regulator: Add Anatop regulator driver

2011-12-27 Thread Mark Brown
On Tue, Dec 27, 2011 at 06:06:27PM +0800, Ying-Chun Liu (PaulLiu) wrote: > (2011年12月22日 19:33), Mark Brown wrote: > >> +#include > >> +#include > > Why does your regulator driver need this? That suggests a layering > > violation. > Sorry, I'm not sure what does this mean. > But if I want to a

Re: [PATCHv2] Regulator: Add Anatop regulator driver

2011-12-27 Thread Ying-Chun Liu (PaulLiu)
(2011年12月22日 19:33), Mark Brown wrote: > >> +#include >> +#include > > Why does your regulator driver need this? That suggests a layering > violation. > Sorry, I'm not sure what does this mean. But if I want to access regulator_constraints, shouldn't I include this header file? Yours Sincer

Re: [PATCHv2] Regulator: Add Anatop regulator driver

2011-12-24 Thread Mark Brown
On Thu, Dec 22, 2011 at 11:33:38AM +, Mark Brown wrote: > On Wed, Dec 21, 2011 at 05:03:31PM +0800, Ying-Chun Liu (PaulLiu) wrote: > > + if (anatop_reg->rdata->control_reg) { > > + val = anatop_reg->rdata->min_bit_val + > > + (uv - reg->constraints->min_uV) / 2500

Re: [PATCHv2] Regulator: Add Anatop regulator driver

2011-12-22 Thread Mark Brown
On Wed, Dec 21, 2011 at 05:03:31PM +0800, Ying-Chun Liu (PaulLiu) wrote: > From: "Ying-Chun Liu (PaulLiu)" > > Anatop regulator driver is used by i.MX6 SoC. The regulator provides > controlling the voltage of PU, CORE, SOC, and some devices. This patch > adds the Anatop regulator driver. It's st