Re: [PATCH v4 02/24] xen/arm: hypercalls

2012-09-14 Thread Marc Zyngier
On 14/09/12 15:02, Stefano Stabellini wrote: > On Fri, 14 Sep 2012, Marc Zyngier wrote: >>> +/* HVC 0xEA1 */ >>> +#ifdef CONFIG_THUMB2_KERNEL >>> +#define xen_hvc .word 0xf7e08ea1 >>> +#else >>> +#define xen_hvc .word 0xe140ea71 >>> +#endif >> >> You should consider using Dave Martin's opcode injec

Re: [PATCH v4 02/24] xen/arm: hypercalls

2012-09-14 Thread Stefano Stabellini
On Fri, 14 Sep 2012, Marc Zyngier wrote: > On 14/09/12 12:13, Stefano Stabellini wrote: > > Use r12 to pass the hypercall number to the hypervisor. > > > > We need a register to pass the hypercall number because we might not > > know it at compile time and HVC only takes an immediate argument. > >

Re: [PATCH v4 02/24] xen/arm: hypercalls

2012-09-14 Thread Marc Zyngier
On 14/09/12 12:13, Stefano Stabellini wrote: > Use r12 to pass the hypercall number to the hypervisor. > > We need a register to pass the hypercall number because we might not > know it at compile time and HVC only takes an immediate argument. > > Among the available registers r12 seems to be the

Re: [PATCH v4 02/24] xen/arm: hypercalls

2012-09-14 Thread Konrad Rzeszutek Wilk
On Fri, Sep 14, 2012 at 12:13:04PM +0100, Stefano Stabellini wrote: > Use r12 to pass the hypercall number to the hypervisor. > > We need a register to pass the hypercall number because we might not > know it at compile time and HVC only takes an immediate argument. > > Among the available regist