Re: [PATCH v2 Ceph] crc32c: add aarch64 optimized crc32c implementation

2015-01-23 Thread Yazen Ghannam
On Fri, Jan 23, 2015 at 10:39 AM, Ard Biesheuvel wrote: > On 23 January 2015 at 16:28, Steve Capper wrote: >> Hi Yazen, >> >> This is looking good, just a few minor comments below. >> >> Cheers, >> -- >> Steve >> >> On Fri, Jan 23, 2015 at 09:13:42AM -0600, Yazen Ghannam wrote: >>> ARMv8 defines

Re: [PATCH v2 Ceph] crc32c: add aarch64 optimized crc32c implementation

2015-01-23 Thread Ard Biesheuvel
On 23 January 2015 at 16:28, Steve Capper wrote: > Hi Yazen, > > This is looking good, just a few minor comments below. > > Cheers, > -- > Steve > > On Fri, Jan 23, 2015 at 09:13:42AM -0600, Yazen Ghannam wrote: >> ARMv8 defines a set of optional CRC32/CRC32C instructions. >> This patch defines an

Re: [PATCH v2 Ceph] crc32c: add aarch64 optimized crc32c implementation

2015-01-23 Thread Steve Capper
Hi Yazen, This is looking good, just a few minor comments below. Cheers, -- Steve On Fri, Jan 23, 2015 at 09:13:42AM -0600, Yazen Ghannam wrote: > ARMv8 defines a set of optional CRC32/CRC32C instructions. > This patch defines an optimized function that uses these > instructions when available