Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-28 Thread Shawn Guo
Hi Dave, On Thu, Dec 29, 2011 at 02:21:03PM +0800, Richard Zhao wrote: > There's still a bug that, after rmmod module, cpu0 still has cpufreq > sysfs entry. > > cpufreq_unregister_driver can not clean up everything. > Is this an known issue to cpufreq core? -- Regards, Shawn

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-28 Thread Richard Zhao
There's still a bug that, after rmmod module, cpu0 still has cpufreq sysfs entry. cpufreq_unregister_driver can not clean up everything. unfortunately, I don't have much time to debug cpufreq core. Log: root@ubuntu:~# insmod /clk-reg-cpufreq.ko clk_reg_cpufreq: regulator cpu get failed. trying

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-28 Thread Shawn Guo
On Wed, Dec 28, 2011 at 12:54:21PM +, Mark Brown wrote: > On Wed, Dec 28, 2011 at 09:06:20PM +0800, Shawn Guo wrote: > > On Wed, Dec 28, 2011 at 12:47:40PM +, Mark Brown wrote: > > > > > One word. You mean I have to always depends on REGULATOR config, right? > > > > Yes. > > > I do not c

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-28 Thread Mark Brown
On Wed, Dec 28, 2011 at 09:06:20PM +0800, Shawn Guo wrote: > On Wed, Dec 28, 2011 at 12:47:40PM +, Mark Brown wrote: > > > One word. You mean I have to always depends on REGULATOR config, right? > > Yes. > I do not care too much. But it puts the driver on an interesting > position, that is

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-28 Thread Shawn Guo
On Wed, Dec 28, 2011 at 12:47:40PM +, Mark Brown wrote: > > One word. You mean I have to always depends on REGULATOR config, right? > > Yes. I do not care too much. But it puts the driver on an interesting position, that is it can work without a regulator driver backing the cpu voltage but i

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-28 Thread Mark Brown
On Wed, Dec 28, 2011 at 08:40:56PM +0800, Richard Zhao wrote: > On Wed, Dec 28, 2011 at 12:14:04PM +, Mark Brown wrote: > > On Wed, Dec 28, 2011 at 08:05:20PM +0800, Richard Zhao wrote: > > > > Looks like the problem with your mail client is that it's wrapping at > > exactly 80 characters whic

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-28 Thread Richard Zhao
On Wed, Dec 28, 2011 at 12:14:04PM +, Mark Brown wrote: > On Wed, Dec 28, 2011 at 08:05:20PM +0800, Richard Zhao wrote: > > Looks like the problem with your mail client is that it's wrapping at > exactly 80 characters which is too little - you need to leave space for > being quoted. I'm using

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-28 Thread Mark Brown
On Wed, Dec 28, 2011 at 08:05:20PM +0800, Richard Zhao wrote: Looks like the problem with your mail client is that it's wrapping at exactly 80 characters which is too little - you need to leave space for being quoted. > On Wed, Dec 28, 2011 at 11:42:37AM +, Mark Brown wrote: > > You can't us

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-28 Thread Richard Zhao
On Wed, Dec 28, 2011 at 11:42:37AM +, Mark Brown wrote: > On Wed, Dec 28, 2011 at 11:31:29AM +0800, Richard Zhao wrote: > > On Wed, Dec 28, 2011 at 11:14:10AM +0800, Richard Zhao wrote: > > > > > + if (cpu_reg) { > > > > + ret = regulator_is_supported_voltag

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-28 Thread Mark Brown
On Wed, Dec 28, 2011 at 11:31:29AM +0800, Richard Zhao wrote: > On Wed, Dec 28, 2011 at 11:14:10AM +0800, Richard Zhao wrote: > > > + if (cpu_reg) { > > > + ret = regulator_is_supported_voltage(cpu_reg, > > > + cpu_volts[i * 2], cpu_volts[i *

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-27 Thread Richard Zhao
On Wed, Dec 28, 2011 at 11:14:10AM +0800, Richard Zhao wrote: > Hi Mark, > > [...] > > + if (cpu_reg) { > > + ret = regulator_is_supported_voltage(cpu_reg, > > + cpu_volts[i * 2], cpu_volts[i * 2 + 1]); > Is there any reason you didn't

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-27 Thread Shawn Guo
On Wed, Dec 28, 2011 at 10:01:13AM +0800, Shawn Guo wrote: > Here is my tag on this patch. > > Acked-by: Shawn Guo > For record, this tag is only valid with the following conditions. * Fix the failure of pm-qa case cpufreq_01 * Fix the failure of module build * Remove the dependency on REGUL

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-27 Thread Richard Zhao
Hi Mark, [...] > + if (cpu_reg) { > + ret = regulator_is_supported_voltage(cpu_reg, > + cpu_volts[i * 2], cpu_volts[i * 2 + 1]); Is there any reason you didn't export symbol regulator_is_supported_voltage? and also it don't have !

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-27 Thread Shawn Guo
On Wed, Dec 28, 2011 at 09:24:05AM +0800, Richard Zhao wrote: > > Have you tried to pass this param from kernel cmdline? What's the > > syntax if we want to pass a 800 MHz max_freq? > clk-reg-cpufreq.max_freq=80 Thanks. I was mistaken on the module name. > > ### cpufreq_05: > > ### test 'on

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-27 Thread Richard Zhao
On Tue, Dec 27, 2011 at 11:05:41PM +0800, Shawn Guo wrote: > Hi Richard, > > On Tue, Dec 27, 2011 at 04:24:19PM +0800, Richard Zhao wrote: > > The driver get cpu operation point table from device tree cpu0 node, > > and adjusts operating points using clk and regulator APIs. > > > > It support sin

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-27 Thread Shawn Guo
Hi Richard, On Tue, Dec 27, 2011 at 04:24:19PM +0800, Richard Zhao wrote: > The driver get cpu operation point table from device tree cpu0 node, > and adjusts operating points using clk and regulator APIs. > > It support single core and multi-core ARM SoCs. But currently it assume > all cores sha