Re: [PATCH 2/4] thermal: Add generic cpufreq cooling implementation

2012-02-26 Thread Amit Kachhap
Hi Durgadoss, Thanks for the detailed review comments. On 24 February 2012 16:34, R, Durgadoss wrote: > Hi Amit, > >> -Original Message- >> From: amit kachhap [mailto:amitdani...@gmail.com] On Behalf Of Amit Daniel >> Kachhap >> Sent: Wednesday, February 22, 2012 3:44 PM >> To: linux...@

RE: [PATCH 2/4] thermal: Add generic cpufreq cooling implementation

2012-02-24 Thread R, Durgadoss
Hi Amit, > -Original Message- > From: amit kachhap [mailto:amitdani...@gmail.com] On Behalf Of Amit Daniel > Kachhap > Sent: Wednesday, February 22, 2012 3:44 PM > To: linux...@lists.linux-foundation.org > Cc: linux-ker...@vger.kernel.org; mj...@srcf.ucam.org; linux- > a...@vger.kernel.org

Re: [PATCH 2/4] thermal: Add generic cpufreq cooling implementation

2012-02-22 Thread Peter Meerwald
Hi, only textual nitpicking below... > user and the binding of these cooling devices to the corresponding > trip points can be easily done as the registration API's return the > cooling device pointer. The user of these api's are responsible for API vs. api use plural s: APIs > +This interfa