Re: [PATCH 2/2] v4l: Add v4l2 subdev driver for S5K4ECGX sensor

2012-07-18 Thread Sangwook Lee
Hi David Thanks for the review! On 17 July 2012 22:45, David Cohen wrote: > Hi Sangwook, > > I've few comments, some just nitpicking. Feel free to disagree. :) > > > On 07/17/2012 07:17 PM, Sangwook Lee wrote: > >> This dirver implements preview mode of the S5K4ECGX sensor. >> capture (snapshot

Re: [PATCH 2/2] v4l: Add v4l2 subdev driver for S5K4ECGX sensor

2012-07-17 Thread David Cohen
Hi Sangwook, I've few comments, some just nitpicking. Feel free to disagree. :) On 07/17/2012 07:17 PM, Sangwook Lee wrote: This dirver implements preview mode of the S5K4ECGX sensor. capture (snapshot) operation, face detection are missing now. Following controls are supported: contrast/satur