Re: [PATCH 2/2] ST-Ericsson db8500 thermal dirver

2012-07-20 Thread Hongbo Zhang
Linus, Thanks for your suggestion, I will follow this when I back to work next Monday. On 15 July 2012 05:47, Linus Walleij wrote: > On Fri, Jul 13, 2012 at 9:51 AM, hongbo.zhang > wrote: > > > From: "hongbo.zhang" > > > > > > Signed-off-by: hongbo.zhang > > A zero-line commit message for a

Re: [PATCH 2/2] ST-Ericsson db8500 thermal dirver

2012-07-14 Thread Linus Walleij
On Fri, Jul 13, 2012 at 9:51 AM, hongbo.zhang wrote: > From: "hongbo.zhang" > > > Signed-off-by: hongbo.zhang A zero-line commit message for an entire new driver is *very* thin. Take this opportunity to describe the hardware and what it can do on a high level and some words on how you implemen

Re: [PATCH 2/2] ST-Ericsson db8500 thermal dirver

2012-07-14 Thread Linus Walleij
On Fri, Jul 13, 2012 at 10:37 AM, Hongbo Zhang wrote: > There are 5 line over 80 characters, is this acceptable or should I obey the > checkpatch.pl strictly? The 80 chars warning is more of a recommendation than a rule. For example: never linebreak error messages, since people may grep for the