Re: [PATCH 02/11] PMIC: Add GPIO Driver for Dialog DA9052

2011-06-10 Thread Arnd Bergmann
On Friday 10 June 2011, Ying-Chun Liu (PaulLiu) wrote: > From: "Ying-Chun Liu (PaulLiu)" > > Add DA9052 gpio driver from Dialog. > Modify Kconfig/Makefile for DA9052 gpio driver. > > Signed-off-by: Zhou Jingyu > Acked-by: Lily Zhang > Signed-off-by: Ying-Chun Liu (PaulLiu) > --- > drivers/gp

Re: [PATCH 02/11] PMIC: Add GPIO Driver for Dialog DA9052

2011-06-10 Thread Andy Green
On 06/10/2011 04:50 AM, Somebody in the thread at some point said: Hi - Just some small comments... It's worth running ./scripts/checkpatch.pl if you didn't already. +#define DRIVER_NAME "da9052-gpio" +static inline struct da9052_gpio_chip *to_da9052_gpio(struct gpio_chip *chip) Don't need