Hi Yong,
> >> +static int __init clk_debugfs_init(void)
> >> +{
> >> + struct preinit_clk *pclk, *tmp;
> >> +
> >> + if (debugfs_initialized())
> >> + init_done = 1;
> >
> > No need to check debugfs_initialised() here; if it's not initialised
> > we're in trouble anyway.
>
>
hi Jeremy,
It's nice to be close :).
And it seems that many people in arm kernel list are also intested in
the clock debug information, maybe we can post next version to that
list and let them know how things are going.
On Thu, Dec 9, 2010 at 10:02 AM, Jeremy Kerr wrote:
> Hi Yong,
>
> We're get
Hi Yong,
We're getting pretty close - just a couple of changes:
> + } else {
> + struct preinit_clk *p;
> + mutex_lock(&preinit_lock);
> + p = kmalloc(sizeof(*p), GFP_KERNEL);
> + if (!p)
> + goto unlock;
> +
Hi Amit,
That's a good reminding. About version number, I am using it in all my
code reviews in different mail list now. About this patch, I planed to
send out a 'v2', however it had been a while since last review, so I
expect a new start.
But I do need to mention the changes.
Changes from last ro
On Fri, Dec 3, 2010 at 1:30 PM, Yong Shen wrote
> Hi Jeremy,
>
> This is latest one for review. I add some minor changes in.
>
> Cheers
> Yong
Yong,
It helps reviewers if you version your patches (PATCHv1, PATCHv2,
etc.) and you list the changes made in each version in the changelog.
See http:/
