Re: [PATCH] cpufreq: interactive: fix racy timer stopping

2012-12-19 Thread Todd Poynor
On Tue, Dec 18, 2012 at 8:46 PM, Nicolas Pitre wrote: > On Tue, 18 Dec 2012, Todd Poynor wrote: > >> I put this up on AOSP Gerrit at >> https://android-review.googlesource.com/#/c/48233/ with a minor change >> to the semaphore field name to be more descriptive and to identify it >> as a semaphore.

Re: [PATCH] cpufreq: interactive: fix racy timer stopping

2012-12-18 Thread Nicolas Pitre
On Tue, 18 Dec 2012, Todd Poynor wrote: > I put this up on AOSP Gerrit at > https://android-review.googlesource.com/#/c/48233/ with a minor change > to the semaphore field name to be more descriptive and to identify it > as a semaphore. > > After some out-of-band discussion it was agreed the race

Re: [PATCH] cpufreq: interactive: fix racy timer stopping

2012-12-18 Thread Todd Poynor
I put this up on AOSP Gerrit at https://android-review.googlesource.com/#/c/48233/ with a minor change to the semaphore field name to be more descriptive and to identify it as a semaphore. After some out-of-band discussion it was agreed the race with the idle notifier definitely exists, but the ra

Re: [PATCH] cpufreq: interactive: fix racy timer stopping

2012-12-17 Thread Todd Poynor
Thanks, I'll merge this to android-3.4 soon. Todd On Thu, Dec 13, 2012 at 9:47 AM, Viresh Kumar wrote: > From: Nicolas Pitre > > Relying on pcpu->governor_enabled alone to ensure proper shutdown > of the governor activities is flawed. The following race is perfectly > possible: > > CPU0