Re: [PATCH v3 01/11] MFD: DA9052 MFD core module

2011-08-09 Thread Mark Brown
On Tue, Aug 09, 2011 at 08:45:47AM +, Ashish Jangam wrote: > > Could do with blank lines between blocks. Though looking at the code > > here I don't understand why these are compile options at all, or if they > > need to be compile options for some reason why they're not independantly > > sel

RE: [PATCH v3 01/11] MFD: DA9052 MFD core module

2011-08-09 Thread Ashish Jangam
> -Original Message- > From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] > Sent: Saturday, August 06, 2011 7:09 PM > To: Ashish Jangam > Cc: sa...@openedhand.com; linux-ker...@vger.kernel.org; Dajun; linaro- > d...@lists.linaro.org > Subject: Re: [PATCH

Re: [PATCH v3 01/11] MFD: DA9052 MFD core module

2011-08-06 Thread Mark Brown
On Fri, Aug 05, 2011 at 07:23:44PM +0530, ashishj3 wrote: Patch v3 seems a little low, we've had *slightly* more versions than that... > +choice > + prompt "Chip Type" > + depends on MFD_DA9053_SPI || MFD_DA9053_I2C > +config PMIC_DA9053AA > + bool "Support Dialog Semiconductor DA9053