Re: [PATCH 01/11] MFD: DA9052 MFD core module v8

2011-12-04 Thread Mark Brown
On Sun, Dec 04, 2011 at 11:50:02AM +, Ashish Jangam wrote: You should fix your mailer to word wrap at less than 80 columns, I've reflowed your text for legibility. > > > regmap-irq has a opaque struct regmap_irq_chip_data which has a member > > > irq_base and this is required for non-primary

RE: [PATCH 01/11] MFD: DA9052 MFD core module v8

2011-12-04 Thread Ashish Jangam
> -Original Message- > From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] > Sent: Friday, December 02, 2011 7:33 PM > To: Ashish Jangam > Cc: a...@arndb.de; sa...@openedhand.com; linux-ker...@vger.kernel.org; > Dajun; linaro-dev@lists.linaro.org > Subject:

Re: [PATCH 01/11] MFD: DA9052 MFD core module v8

2011-12-02 Thread Mark Brown
On Fri, Dec 02, 2011 at 01:57:49PM +, Ashish Jangam wrote: > > On Fri, Nov 18, 2011 at 02:49:54PM +0530, Ashish Jangam wrote: > > > + da9052_i2c->bustype = BUS_I2C; > > bustype should be redundant now, it certianly doesn't seem to be > > referred to in this patch. > This is required in the T

RE: [PATCH 01/11] MFD: DA9052 MFD core module v8

2011-12-02 Thread Ashish Jangam
ect: Re: [PATCH 01/11] MFD: DA9052 MFD core module v8 > > On Fri, Nov 18, 2011 at 02:49:54PM +0530, Ashish Jangam wrote: > > > + da9052_i2c->bustype = BUS_I2C; > > bustype should be redundant now, it certianly doesn't seem to be > referred

Re: [PATCH 01/11] MFD: DA9052 MFD core module v8

2011-11-24 Thread Mark Brown
On Fri, Nov 18, 2011 at 02:49:54PM +0530, Ashish Jangam wrote: There's still a few issues in here. It'd be very much easier to review this stuff if you split the patch down into smaller patches, for example having the ADC, SPI and I2C as separate patches. The bigger each individual e-mail is the