Re: [PATCH] Samsung/Arndale: fix RELEASE build with ARMLINUXGCC

2013-02-13 Thread Reece R. Pollack
On 02/13/2013 10:44 AM, Olivier Martin wrote: > Instead of using: > #if !defined(MDEPKG_NDEBUG) > (...) > #endif > > It would be better to use: > DEBUG_CODE_BEGIN(); > (...) > DEBUG_CODE_END(); > > The reason is you can be in debug build and disable debug code (and/or > disable other things suc

RE: [PATCH] Samsung/Arndale: fix RELEASE build with ARMLINUXGCC

2013-02-13 Thread Olivier Martin
Instead of using: #if !defined(MDEPKG_NDEBUG) (...) #endif It would be better to use: DEBUG_CODE_BEGIN(); (...) DEBUG_CODE_END(); The reason is you can be in debug build and disable debug code (and/or disable other things such as ASSERT). See definition of PcdDebugPropertyMask for the full li