Re: Add common interface for clock debug information

2010-11-10 Thread Yong Shen
Hi Jeremy, It's nice to know that your clock update is coming soon. I would not waster your time talking more in detail here now, since everything will be more clear after your code comes out. Thanks again for sharing, and talk to you later. Yong On Wed, Nov 10, 2010 at 4:31 PM, Jeremy Kerr wrot

Re: Add common interface for clock debug information

2010-11-10 Thread Jeremy Kerr
Hi Yong, > This means that you have already forced each SOC to have a unified > 'struct clk', or at least force some fields inside the struct tp be unified, > right? > My understanding is that leaving 'struct clk' definition to SOC related > code is to give freedom for 'struct clk' definition to S

Re: Add common interface for clock debug information

2010-11-09 Thread Yong Shen
> > > > > > #define INIT_CLK(name, o) { > \ > >.ops= &o, > \ > >.enable_count = 0, > \ > >.lock.mutex = __MUTEX_INITIALIZER(name.lock.mutex), \ > >.name

Re: Add common interface for clock debug information

2010-11-09 Thread Eric Miao
// snip > This would give us: > > #define CLK_NAME_LEN    16 > > struct clk { >        const struct clk_ops    *ops; >        unsigned int                    enable_count; >        struct mutex                    mutex; >        const char                      name[CLK_NAME_LEN]; > }; > > #define

Re: Add common interface for clock debug information

2010-11-09 Thread Yong Shen
Hi Jeremy, Thanks for comments. Please see my further discussion. > > > 1. Create clock information based on common clock device, more specific, > > based on struct clk_lookup. Since platform drivers are supposed to > register > > their clock > > using 'void clkdev_add(struct clk_lookup *cl)', c

Re: Add common interface for clock debug information

2010-11-09 Thread Jeremy Kerr
Hi Yong, > To do so, I need to make somethings done, and some of them are related to > common clock code, for which I am more than happy to hear your comments. Definitely, I'm happy to help out. > 1. Create clock information based on common clock device, more specific, > based on struct clk_look

Add common interface for clock debug information

2010-11-08 Thread Yong Shen
Hi Jeremy, In power management group of linaro, we want to export debug information of clock to user space and make a common interface to all the SOC platform. Currently, each SOC platform has their own way to export clock information, like freesale and TI, which is not ideal. To do so, I need to