Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Ian Campbell
On Fri, 2012-07-27 at 15:21 +0100, Russell King - ARM Linux wrote: > On Fri, Jul 27, 2012 at 02:02:18PM +0100, Stefano Stabellini wrote: > > > > > +/** > > > > > + * hypercall.h > > > > > + * > > > > > + * Linux-specific hy

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Ian Campbell
On Fri, 2012-07-27 at 14:02 +0100, Stefano Stabellini wrote: > On Fri, 27 Jul 2012, Ian Campbell wrote: > > On Thu, 2012-07-26 at 17:33 +0100, Konrad Rzeszutek Wilk wrote: > > > On Thu, Jul 26, 2012 at 04:33:44PM +0100, Stefano Stabellini wrote: > > > > Use r12 to pass the hypercall number to the h

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Russell King - ARM Linux
On Fri, Jul 27, 2012 at 03:39:31PM +0100, Ian Campbell wrote: > On Fri, 2012-07-27 at 15:21 +0100, Russell King - ARM Linux wrote: > > On Fri, Jul 27, 2012 at 02:02:18PM +0100, Stefano Stabellini wrote: > > > > > > +/** > >

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2012, Russell King - ARM Linux wrote: > On Fri, Jul 27, 2012 at 02:02:18PM +0100, Stefano Stabellini wrote: > > > > > +/** > > > > > + * hypercall.h > > > > > + * > > > > > + * Linux-specific hypervisor handl

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Russell King - ARM Linux
On Fri, Jul 27, 2012 at 02:02:18PM +0100, Stefano Stabellini wrote: > > > > +/** > > > > + * hypercall.h > > > > + * > > > > + * Linux-specific hypervisor handling. > > > > + * > > > > + * Stefano Stabellini , Citrix, 2012

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2012, Ian Campbell wrote: > > > > Should this comment be by 'privcmd_call'? > > > > > > When we add a 5 argument hypercall I suppose we'll see the required > > > push/pop of r4 added to this macro too. > > > > For performance and simplicity I would add a second macro that push/pop

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Stefano Stabellini
On Fri, 27 Jul 2012, Ian Campbell wrote: > On Thu, 2012-07-26 at 17:33 +0100, Konrad Rzeszutek Wilk wrote: > > On Thu, Jul 26, 2012 at 04:33:44PM +0100, Stefano Stabellini wrote: > > > Use r12 to pass the hypercall number to the hypervisor. > > > > > > We need a register to pass the hypercall numb

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread David Vrabel
On 26/07/12 16:33, Stefano Stabellini wrote: > > + * The hvc ISS is required to be 0xEA1, that is the Xen specific ARM > + * hypercall tag. Is this number, 0xea1, assigned to Xen by some external body? David ___ linaro-dev mailing list linaro-dev@list

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:33:44PM +0100, Stefano Stabellini wrote: > Use r12 to pass the hypercall number to the hypervisor. > > We need a register to pass the hypercall number because we might not > know it at compile time and HVC only takes an immediate argument. > > Among the available regist

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Ian Campbell
On Thu, 2012-07-26 at 17:33 +0100, Konrad Rzeszutek Wilk wrote: > On Thu, Jul 26, 2012 at 04:33:44PM +0100, Stefano Stabellini wrote: > > Use r12 to pass the hypercall number to the hypervisor. > > > > We need a register to pass the hypercall number because we might not > > know it at compile time

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-27 Thread Ian Campbell
On Thu, 2012-07-26 at 17:56 +0100, David Vrabel wrote: > On 26/07/12 16:33, Stefano Stabellini wrote: > > > > + * The hvc ISS is required to be 0xEA1, that is the Xen specific ARM > > + * hypercall tag. > > Is this number, 0xea1, assigned to Xen by some external body? The value and semantics of

Re: [Xen-devel] [PATCH 02/24] xen/arm: hypercalls

2012-07-26 Thread Stefano Stabellini
On Thu, 26 Jul 2012, David Vrabel wrote: > On 26/07/12 16:33, Stefano Stabellini wrote: > > > > + * The hvc ISS is required to be 0xEA1, that is the Xen specific ARM > > + * hypercall tag. > > Is this number, 0xea1, assigned to Xen by some external body? I am not aware of any "external body" tha