Re: [U-Boot] [PATCH] S5PC2XX: GPIO Macro Values Corrected.

2011-04-18 Thread Minkyu Kang
Dear Chander Kashyap, On 18 April 2011 12:50, Chander Kashyap wrote: > > No need to change. As existing gpio configuration is as per s5pc1xx > specification. According to S5PC110 TRM, DRV levels are as following, 00 = 1x 10 = 2x 01 = 3x 11 = 4x Please fix it at s5pc1xx also. Thanks Minkyu Kan

Re: [U-Boot] [PATCH] S5PC2XX: GPIO Macro Values Corrected.

2011-04-18 Thread Minkyu Kang
Dear Chander Kashyap, On 18 April 2011 13:53, Chander Kashyap wrote: > Macro values for Pull Up and Driver Strength were wrong. > Signed-off-by: Chander Kashyap > --- >  arch/arm/include/asm/arch-s5pc2xx/gpio.h |    7 +++ >  1 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/a

Re: [U-Boot] [PATCH] S5PC2XX: GPIO Macro Values Corrected.

2011-04-18 Thread Chander Kashyap
Dear Minkyu, On 18 April 2011 13:00, Minkyu Kang wrote: > Dear Chander Kashyap, > > On 18 April 2011 12:50, Chander Kashyap > wrote: > > > > No need to change. As existing gpio configuration is as per s5pc1xx > > specification. > > According to S5PC110 TRM, DRV levels are as following, > > 00 =

Re: [U-Boot] [PATCH] S5PC2XX: GPIO Macro Values Corrected.

2011-04-17 Thread Chander Kashyap
Dear Minkyu, On 15 April 2011 11:59, Minkyu Kang wrote: > Dear Chander Kashyap, > > On 14 April 2011 18:17, Chander Kashyap > wrote: > > Macro values for Pull Up and Driver Strength were wrong. > > > > Signed-off-by: Chander Kashyap > > --- > > arch/arm/include/asm/arch-s5pc2xx/gpio.h |6

Re: [U-Boot] [PATCH] S5PC2XX: GPIO Macro Values Corrected.

2011-04-15 Thread Minkyu Kang
Dear Chander Kashyap, On 14 April 2011 18:17, Chander Kashyap wrote: > Macro values for Pull Up and Driver Strength were wrong. > > Signed-off-by: Chander Kashyap > --- >  arch/arm/include/asm/arch-s5pc2xx/gpio.h |    6 +++--- >  1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/