Re: [RFC V1 1/4] cpufreq: add arm soc generic cpufreq driver

2011-12-16 Thread Richard Zhao
On Fri, Dec 16, 2011 at 08:24:23AM +, Russell King - ARM Linux wrote: > On Thu, Dec 15, 2011 at 12:50:07PM -0600, Mark Langsdorf wrote: > > I'd prefer to see clk_get90 replaced with of_clk_get() and > > get_this_cpu_node() from the clk-cpufreq driver by Jamie Iles that > > I resubmitted yesterd

Re: [RFC V1 1/4] cpufreq: add arm soc generic cpufreq driver

2011-12-16 Thread Russell King - ARM Linux
On Thu, Dec 15, 2011 at 12:50:07PM -0600, Mark Langsdorf wrote: > I'd prefer to see clk_get90 replaced with of_clk_get() and > get_this_cpu_node() from the clk-cpufreq driver by Jamie Iles that > I resubmitted yesterday. Why isn't of_clk_get() hidden inside clk_get() ? ___

Re: [RFC V1 1/4] cpufreq: add arm soc generic cpufreq driver

2011-12-15 Thread Richard Zhao
On Thu, Dec 15, 2011 at 08:29:11PM +, Russell King - ARM Linux wrote: > On Thu, Dec 15, 2011 at 07:16:35PM +0800, Richard Zhao wrote: > > +#ifdef CONFIG_SMP > > + /* loops_per_jiffy is not updated by the cpufreq core for SMP systems. > > +* So update it for all CPUs. > > +*/ > > + f

Re: [RFC V1 1/4] cpufreq: add arm soc generic cpufreq driver

2011-12-15 Thread Richard Zhao
On Thu, Dec 15, 2011 at 12:50:07PM -0600, Mark Langsdorf wrote: > Comments below. I tested this on the Calxeda Highbank SoC using > QEMU. I found one definite error and a few things I would change. Thanks for your test. > > On 12/15/2011 05:16 AM, Richard Zhao wrote: > >It support single core and

Re: [RFC V1 1/4] cpufreq: add arm soc generic cpufreq driver

2011-12-15 Thread Russell King - ARM Linux
On Thu, Dec 15, 2011 at 07:16:35PM +0800, Richard Zhao wrote: > +#ifdef CONFIG_SMP > + /* loops_per_jiffy is not updated by the cpufreq core for SMP systems. > + * So update it for all CPUs. > + */ > + for_each_possible_cpu(cpu) > + per_cpu(cpu_data, cpu).loops_per_jif

Re: [RFC V1 1/4] cpufreq: add arm soc generic cpufreq driver

2011-12-15 Thread Mark Langsdorf
Comments below. I tested this on the Calxeda Highbank SoC using QEMU. I found one definite error and a few things I would change. On 12/15/2011 05:16 AM, Richard Zhao wrote: It support single core and multi-core ARM SoCs. But it assume all cores share the same frequency and voltage. Signed-off-

Re: [RFC V1 1/4] cpufreq: add arm soc generic cpufreq driver

2011-12-15 Thread Richard Zhao
TODO: - add voltage change. Thanks Richard ___ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev

[RFC V1 1/4] cpufreq: add arm soc generic cpufreq driver

2011-12-15 Thread Richard Zhao
It support single core and multi-core ARM SoCs. But it assume all cores share the same frequency and voltage. Signed-off-by: Richard Zhao --- drivers/cpufreq/Kconfig.arm |8 ++ drivers/cpufreq/Makefile |1 + drivers/cpufreq/arm-cpufreq.c | 260