Re: [linux-pm] [RFC PATCH 2/2] thermal: Add generic cpu cooling implementation

2012-02-07 Thread Eduardo Valentin
Hello Amit, On Tue, Feb 07, 2012 at 10:21:15AM -0800, Amit Kachhap wrote: > Hi eduardo, > > Again thanks for the review. > > On 7 February 2012 00:25, Eduardo Valentin wrote: > > Hello Amit, > > > > On Tue, Dec 13, 2011 at 08:43:16PM +0530, Amit Daniel Kachhap wrote: > >> This patch adds suppor

Re: [linux-pm] [RFC PATCH 2/2] thermal: Add generic cpu cooling implementation

2012-02-07 Thread Amit Kachhap
Hi eduardo, Again thanks for the review. On 7 February 2012 00:25, Eduardo Valentin wrote: > Hello Amit, > > On Tue, Dec 13, 2011 at 08:43:16PM +0530, Amit Daniel Kachhap wrote: >> This patch adds support for generic cpu thermal cooling low level >> implementations using frequency scaling and cp

Re: [linux-pm] [RFC PATCH 2/2] thermal: Add generic cpu cooling implementation

2012-02-07 Thread Eduardo Valentin
Hello Amit, On Tue, Dec 13, 2011 at 08:43:16PM +0530, Amit Daniel Kachhap wrote: > This patch adds support for generic cpu thermal cooling low level > implementations using frequency scaling and cpuhotplugg currently. > Different cpu related cooling devices can be registered by the > user and the

Re: [RFC PATCH 2/2] thermal: Add generic cpu cooling implementation

2012-02-02 Thread Amit Kachhap
On 1 February 2012 20:27, Matthew Garrett wrote: > On Tue, Dec 13, 2011 at 08:43:16PM +0530, Amit Daniel Kachhap wrote: >> This patch adds support for generic cpu thermal cooling low level >> implementations using frequency scaling and cpuhotplugg currently. > > We've been over this kind of thing

Re: [RFC PATCH 2/2] thermal: Add generic cpu cooling implementation

2012-02-01 Thread Matthew Garrett
On Tue, Dec 13, 2011 at 08:43:16PM +0530, Amit Daniel Kachhap wrote: > This patch adds support for generic cpu thermal cooling low level > implementations using frequency scaling and cpuhotplugg currently. We've been over this kind of thing in the past. cpu hotplug is a relatively expensive opera

Re: [RFC PATCH 2/2] thermal: Add generic cpu cooling implementation

2012-01-16 Thread Rob Lee
>> I don't like how ACTIVE does not have available notification callbacks >> like HOT and CRITICAL do.  Perhaps I fail to grasp why they aren't there >> but besides just applying a cooling device, one might want to do something >> else as well upon hitting these trip points.  So that said, it might

Re: [RFC PATCH 2/2] thermal: Add generic cpu cooling implementation

2012-01-12 Thread Amit Kachhap
On 11 January 2012 13:32, Rob Lee wrote: > Hey Amit, I was able to use your code on an i.MX6Q thermal > implementation and it seemed to work pretty well.  Thanks for adding > this.  A couple of comments below. Thanks for testing and reviewing the code. > > On Tue, Dec 13, 2011 at 9:13 AM, Amit Dan

Re: [RFC PATCH 2/2] thermal: Add generic cpu cooling implementation

2012-01-11 Thread Rob Lee
Hey Amit, I was able to use your code on an i.MX6Q thermal implementation and it seemed to work pretty well. Thanks for adding this. A couple of comments below. On Tue, Dec 13, 2011 at 9:13 AM, Amit Daniel Kachhap wrote: > This patch adds support for generic cpu thermal cooling low level > impl

[RFC PATCH 2/2] thermal: Add generic cpu cooling implementation

2011-12-13 Thread Amit Daniel Kachhap
This patch adds support for generic cpu thermal cooling low level implementations using frequency scaling and cpuhotplugg currently. Different cpu related cooling devices can be registered by the user and the binding of these cooling devices to the corresponding trip points can be easily done as th