Re: [RFC 3/4] ARM: topology: Update cpu_power according to DT information

2012-06-13 Thread Peter Zijlstra
On Wed, 2012-06-13 at 16:54 +0200, Vincent Guittot wrote: > On 13 June 2012 15:07, Peter Zijlstra wrote: > > On Tue, 2012-06-12 at 14:02 +0200, Vincent Guittot wrote: > >> +struct cpu_capacity cpu_capacity[NR_CPUS]; > > > > I know ARM isn't likely to suffer from the 4k cpu issue, but is there a >

Re: [RFC 3/4] ARM: topology: Update cpu_power according to DT information

2012-06-13 Thread Vincent Guittot
On 13 June 2012 15:07, Peter Zijlstra wrote: > On Tue, 2012-06-12 at 14:02 +0200, Vincent Guittot wrote: >> +struct cpu_capacity cpu_capacity[NR_CPUS]; > > I know ARM isn't likely to suffer from the 4k cpu issue, but is there a > reason to use a NR_CPUS array over a per-cpu variable? At this stag

Re: [RFC 3/4] ARM: topology: Update cpu_power according to DT information

2012-06-13 Thread Nicolas Pitre
On Wed, 13 Jun 2012, Peter Zijlstra wrote: > On Tue, 2012-06-12 at 14:02 +0200, Vincent Guittot wrote: > > +#ifdef CONFIG_OF > > That must really be the worst CONFIG_ name ever.. Indeed! We must corner Grant to do a s/CONFIG_OF/CONFIG_DEVICE_TREE/ on the whole tree and send the patch to Linus.

Re: [RFC 3/4] ARM: topology: Update cpu_power according to DT information

2012-06-13 Thread Vincent Guittot
On 13 June 2012 15:32, Peter Zijlstra wrote: > On Wed, 2012-06-13 at 15:29 +0200, Vincent Guittot wrote: >> In fact, there is 2 tracks, one for a power aware scheduler and one >> for setting the capacity of each core of a big.LITTLE system. This >> patch is for the latter and is not directly link

Re: [RFC 3/4] ARM: topology: Update cpu_power according to DT information

2012-06-13 Thread Peter Zijlstra
On Wed, 2012-06-13 at 15:29 +0200, Vincent Guittot wrote: > In fact, there is 2 tracks, one for a power aware scheduler and one > for setting the capacity of each core of a big.LITTLE system. This > patch is for the latter and is not directly link to the power because > the default/performance mode

Re: [RFC 3/4] ARM: topology: Update cpu_power according to DT information

2012-06-13 Thread Vincent Guittot
On 13 June 2012 14:47, Peter Zijlstra wrote: > On Wed, 2012-06-13 at 18:14 +0530, Amit Kucheria wrote: >> Various discussions around power-aware scheduling have amplified the >> need for the scheduler to have some knowledge of DVFS. This would then >> require the scheduler to track 'cpu_power' ( =

Re: [RFC 3/4] ARM: topology: Update cpu_power according to DT information

2012-06-13 Thread Peter Zijlstra
On Tue, 2012-06-12 at 14:02 +0200, Vincent Guittot wrote: > Use cpu compatibility field and clock-frequency field of DT to > estimate the capacity of each core of the system > Can you provide a little description in the form of a code comment near update_cpu_power() as to wtf all that does? This O

Re: [RFC 3/4] ARM: topology: Update cpu_power according to DT information

2012-06-13 Thread Peter Zijlstra
On Tue, 2012-06-12 at 14:02 +0200, Vincent Guittot wrote: > +#ifdef CONFIG_OF That must really be the worst CONFIG_ name ever.. ___ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev

Re: [RFC 3/4] ARM: topology: Update cpu_power according to DT information

2012-06-13 Thread Peter Zijlstra
On Tue, 2012-06-12 at 14:02 +0200, Vincent Guittot wrote: > +struct cpu_capacity cpu_capacity[NR_CPUS]; I know ARM isn't likely to suffer from the 4k cpu issue, but is there a reason to use a NR_CPUS array over a per-cpu variable? ___ linaro-dev mailing

Re: [RFC 3/4] ARM: topology: Update cpu_power according to DT information

2012-06-13 Thread Jean Pihet
Hi Amit, Peter, On Wed, Jun 13, 2012 at 2:47 PM, Peter Zijlstra wrote: > On Wed, 2012-06-13 at 18:14 +0530, Amit Kucheria wrote: >> Various discussions around power-aware scheduling have amplified the >> need for the scheduler to have some knowledge of DVFS. This would then >> require the schedul

Re: [RFC 3/4] ARM: topology: Update cpu_power according to DT information

2012-06-13 Thread Peter Zijlstra
On Wed, 2012-06-13 at 18:14 +0530, Amit Kucheria wrote: > Various discussions around power-aware scheduling have amplified the > need for the scheduler to have some knowledge of DVFS. This would then > require the scheduler to track 'cpu_power' ( = max power) and perhaps > a new variable 'current_p

Re: [RFC 3/4] ARM: topology: Update cpu_power according to DT information

2012-06-13 Thread Amit Kucheria
On Wed, Jun 13, 2012 at 3:14 PM, Vincent Guittot wrote: > On 13 June 2012 10:59, Jean Pihet wrote: >> Vincent, >> >> On Tue, Jun 12, 2012 at 2:02 PM, Vincent Guittot >> wrote: >>> Use cpu compatibility field and clock-frequency field of DT to >>> estimate the capacity of each core of the system

Re: [RFC 3/4] ARM: topology: Update cpu_power according to DT information

2012-06-13 Thread Vincent Guittot
On 13 June 2012 10:59, Jean Pihet wrote: > Vincent, > > On Tue, Jun 12, 2012 at 2:02 PM, Vincent Guittot > wrote: >> Use cpu compatibility field and clock-frequency field of DT to >> estimate the capacity of each core of the system >> >> Signed-off-by: Vincent Guittot >> --- >>  arch/arm/kernel/

Re: [RFC 3/4] ARM: topology: Update cpu_power according to DT information

2012-06-13 Thread Jean Pihet
Vincent, On Tue, Jun 12, 2012 at 2:02 PM, Vincent Guittot wrote: > Use cpu compatibility field and clock-frequency field of DT to > estimate the capacity of each core of the system > > Signed-off-by: Vincent Guittot > --- >  arch/arm/kernel/topology.c |  122 > ++

[RFC 3/4] ARM: topology: Update cpu_power according to DT information

2012-06-12 Thread Vincent Guittot
Use cpu compatibility field and clock-frequency field of DT to estimate the capacity of each core of the system Signed-off-by: Vincent Guittot --- arch/arm/kernel/topology.c | 122 1 file changed, 122 insertions(+) diff --git a/arch/arm/kernel/topol