On Wed, 2012-06-13 at 20:27 +0100, Andy Whitcroft wrote:
> Actually if it was a new line, it would have been reported, at least in
> theory:
>
> # check for memory barriers without a comment.
> if ($line =~
>
> /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|
On Wed, 2012-06-13 at 20:27 +0100, Andy Whitcroft wrote:
> On Wed, Jun 13, 2012 at 02:52:49PM +0200, Peter Zijlstra wrote:
> > On Tue, 2012-06-12 at 14:02 +0200, Vincent Guittot wrote:
> > > }
> > > smp_wmb();
> > > }
> >
> > You know what.. we should make checkpatch report an er
On Wed, Jun 13, 2012 at 02:52:49PM +0200, Peter Zijlstra wrote:
> On Tue, 2012-06-12 at 14:02 +0200, Vincent Guittot wrote:
> > }
> > smp_wmb();
> > }
>
> You know what.. we should make checkpatch report an error for memory
> barriers that don't have a comment.
>
> I know this
On Tue, 2012-06-12 at 14:02 +0200, Vincent Guittot wrote:
> }
> smp_wmb();
> }
You know what.. we should make checkpatch report an error for memory
barriers that don't have a comment.
I know this isn't added by this patch, but every time I see something
like it I cry a little.
On 13 June 2012 10:50, Jean Pihet wrote:
> Hi Vincent,
>
> On Tue, Jun 12, 2012 at 2:02 PM, Vincent Guittot
> wrote:
>> Add infrastructure to be able to modify the cpu_power of each core
>>
>> Signed-off-by: Vincent Guittot
>> ---
>> arch/arm/include/asm/topology.h | 2 ++
>> arch/arm/kernel
Hi Vincent,
On Tue, Jun 12, 2012 at 2:02 PM, Vincent Guittot
wrote:
> Add infrastructure to be able to modify the cpu_power of each core
>
> Signed-off-by: Vincent Guittot
> ---
> arch/arm/include/asm/topology.h | 2 ++
> arch/arm/kernel/topology.c | 36 +++
Add infrastructure to be able to modify the cpu_power of each core
Signed-off-by: Vincent Guittot
---
arch/arm/include/asm/topology.h |2 ++
arch/arm/kernel/topology.c | 36 +++-
2 files changed, 37 insertions(+), 1 deletion(-)
diff --git a/arch/arm/in
