Re: [RFC] Add Arm cpu topology definition

2011-06-22 Thread Amit Kucheria
On 11 Jun 22, Catalin Marinas wrote: > On Tue, Jun 21, 2011 at 01:36:15PM -0700, Stephen Boyd wrote: > > On 06/16/2011 11:54 PM, Vincent Guittot wrote: > > > On 16 June 2011 21:40, Stephen Boyd wrote: > > >> The ARM ARM says these fields are IMPLEMENTATION DEFINED meaning that > > >> different ven

Re: [RFC] Add Arm cpu topology definition

2011-06-22 Thread Catalin Marinas
On Tue, Jun 21, 2011 at 01:36:15PM -0700, Stephen Boyd wrote: > On 06/16/2011 11:54 PM, Vincent Guittot wrote: > > On 16 June 2011 21:40, Stephen Boyd wrote: > >> The ARM ARM says these fields are IMPLEMENTATION DEFINED meaning that > >> different vendors may attribute different meaning to these f

Re: [RFC] Add Arm cpu topology definition

2011-06-21 Thread Stephen Boyd
On 06/16/2011 11:54 PM, Vincent Guittot wrote: > On 16 June 2011 21:40, Stephen Boyd wrote: >> The ARM ARM says these fields are IMPLEMENTATION DEFINED meaning that >> different vendors may attribute different meaning to these fields if >> they wish. Does that mean this should be a platform_*() fu

Re: [RFC] Add Arm cpu topology definition

2011-06-17 Thread Stephen Boyd
On 06/16/2011 01:49 AM, Vincent Guittot wrote: > +config SCHED_MC > + bool "Multi-core scheduler support" > + depends on SMP && ARM_CPU_TOPOLOGY > + default n > + help > + Multi-core scheduler support improves the CPU scheduler's decision > + making when dealing with mul

Re: [RFC] Add Arm cpu topology definition

2011-06-17 Thread Vincent Guittot
On 16 June 2011 23:13, Russell King - ARM Linux wrote: > On Thu, Jun 16, 2011 at 10:49:13AM +0200, Vincent Guittot wrote: >> @@ -219,6 +219,24 @@ source "kernel/Kconfig.freezer" >> >>  menu "System Type" >> >> +config SCHED_MC >> +     bool "Multi-core scheduler support" >> +     depends on SMP &&

Re: [RFC] Add Arm cpu topology definition

2011-06-16 Thread Vincent Guittot
On 16 June 2011 21:40, Stephen Boyd wrote: > On 06/16/2011 01:49 AM, Vincent Guittot wrote: >> +config SCHED_MC >> +     bool "Multi-core scheduler support" >> +     depends on SMP && ARM_CPU_TOPOLOGY >> +     default n >> +     help >> +       Multi-core scheduler support improves the CPU schedul

Re: [RFC] Add Arm cpu topology definition

2011-06-16 Thread Russell King - ARM Linux
On Thu, Jun 16, 2011 at 10:49:13AM +0200, Vincent Guittot wrote: > @@ -219,6 +219,24 @@ source "kernel/Kconfig.freezer" > > menu "System Type" > > +config SCHED_MC > + bool "Multi-core scheduler support" > + depends on SMP && ARM_CPU_TOPOLOGY > + default n > + help > + Mult

Re: [RFC] Add Arm cpu topology definition

2011-06-16 Thread Vincent Guittot
On 16 June 2011 15:24, Christian Robottom Reis wrote: > On Thu, Jun 16, 2011 at 10:49:13AM +0200, Vincent Guittot wrote: >> @@ -219,6 +219,24 @@ source "kernel/Kconfig.freezer" >> >>  menu "System Type" >> >> +config SCHED_MC >> +     bool "Multi-core scheduler support" >> +     depends on SMP &&

Re: [RFC] Add Arm cpu topology definition

2011-06-16 Thread Samuel Thibault
Hello, Vincent Guittot, le Thu 16 Jun 2011 10:49:13 +0200, a écrit : > The affinity between Arm processors is defined in the MPIDR register. > We can identify which processors are in the same cluster, > and which ones have performance interdependency. The cpu topology > of an Arm platform can be

Re: [RFC] Add Arm cpu topology definition

2011-06-16 Thread Samuel Thibault
Vincent Guittot, le Thu 16 Jun 2011 11:44:30 +0200, a écrit : > The output of hwloc-gather-topology is : > > Machine (phys=0 local=280840KB total=280840KB) > Socket #0 (phys=3) > Core #0 (phys=0) > PU #0 (phys=0) > Core #1 (phys=1) > PU #1 (phys=1) > depth 0:1 Machine

Re: [RFC] Add Arm cpu topology definition

2011-06-16 Thread Christian Robottom Reis
On Thu, Jun 16, 2011 at 10:49:13AM +0200, Vincent Guittot wrote: > @@ -219,6 +219,24 @@ source "kernel/Kconfig.freezer" > > menu "System Type" > > +config SCHED_MC > + bool "Multi-core scheduler support" > + depends on SMP && ARM_CPU_TOPOLOGY > + default n > + help > + Mult

Re: [RFC] Add Arm cpu topology definition

2011-06-16 Thread Vincent Guittot
On 16 June 2011 13:48, Amit Kucheria wrote: > On 11 Jun 16, Vincent Guittot wrote: >> The affinity between Arm processors is defined in the MPIDR register. >> We can identify which processors are in the same cluster, >> and which ones have performance interdependency. The cpu topology >>  of an Ar

Re: [RFC] Add Arm cpu topology definition

2011-06-16 Thread Vincent Guittot
On 16 June 2011 13:55, Amit Kachhap wrote: > I have some doubts about the bit fields of the MPIDR register. > Comments added below. > On 16 June 2011 14:19, Vincent Guittot wrote: >> The affinity between Arm processors is defined in the MPIDR register. >> We can identify which processors are in t

Re: [RFC] Add Arm cpu topology definition

2011-06-16 Thread Vincent Guittot
On 16 June 2011 12:49, Daniel Lezcano wrote: > On 06/16/2011 10:49 AM, Vincent Guittot wrote: >> >> The affinity between Arm processors is defined in the MPIDR register. >> We can identify which processors are in the same cluster, >> and which ones have performance interdependency. The cpu topolog

Re: [RFC] Add Arm cpu topology definition

2011-06-16 Thread Amit Kachhap
I have some doubts about the bit fields of the MPIDR register. Comments added below. On 16 June 2011 14:19, Vincent Guittot wrote: > The affinity between Arm processors is defined in the MPIDR register. > We can identify which processors are in the same cluster, > and which ones have performance i

Re: [RFC] Add Arm cpu topology definition

2011-06-16 Thread Amit Kucheria
On 11 Jun 16, Vincent Guittot wrote: > The affinity between Arm processors is defined in the MPIDR register. > We can identify which processors are in the same cluster, > and which ones have performance interdependency. The cpu topology > of an Arm platform can be set thanks to this register and t

Re: [RFC] Add Arm cpu topology definition

2011-06-16 Thread Daniel Lezcano
On 06/16/2011 10:49 AM, Vincent Guittot wrote: The affinity between Arm processors is defined in the MPIDR register. We can identify which processors are in the same cluster, and which ones have performance interdependency. The cpu topology of an Arm platform can be set thanks to this register

Re: [RFC] Add Arm cpu topology definition

2011-06-16 Thread Vincent Guittot
On 16 June 2011 11:47, Samuel Thibault wrote: > Vincent Guittot, le Thu 16 Jun 2011 11:44:30 +0200, a écrit : >> The output of hwloc-gather-topology is : >> >> Machine (phys=0 local=280840KB total=280840KB) >>   Socket #0 (phys=3) >>     Core #0 (phys=0) >>       PU #0 (phys=0) >>     Core #1 (phy

Re: [RFC] Add Arm cpu topology definition

2011-06-16 Thread Vincent Guittot
On 16 June 2011 10:55, Samuel Thibault wrote: > Hello, > > Vincent Guittot, le Thu 16 Jun 2011 10:49:13 +0200, a écrit : >> The affinity between Arm processors is defined in the MPIDR register. >> We can identify which processors are in the same cluster, >> and which ones have performance interdep

[RFC] Add Arm cpu topology definition

2011-06-16 Thread Vincent Guittot
The affinity between Arm processors is defined in the MPIDR register. We can identify which processors are in the same cluster, and which ones have performance interdependency. The cpu topology of an Arm platform can be set thanks to this register and this topology is then used by sched_mc and sch