Re: [PATCHv2] make mc13783 regulator code generic

2010-12-02 Thread Sascha Hauer
Hi Yong, On Wed, Dec 01, 2010 at 03:15:55PM +0800, Yong Shen wrote: > Hi there, > > This is the v2 with some changes according to comments from v1. There > will be few patches coming out after this one, for mc13892 regulator > to share some code with mc13783. > > Still, cause the firewall proble

Re: [PATCHv2] make mc13783 regulator code generic

2010-12-02 Thread Mark Brown
On Wed, Dec 01, 2010 at 03:15:55PM +0800, Yong Shen wrote: > move some common functions and micros of mc13783 regulaor driver to > a seperate file, which makes it possible for mc13892 to share code. You've done way more than this in the patch - you've also renamed a lot of things and done other

Re: [PATCHv2] make mc13783 regulator code generic

2010-12-01 Thread Yong Shen
Hi, please see inline feedback. On Wed, Dec 1, 2010 at 7:25 PM, Mark Brown wrote: > On Wed, Dec 01, 2010 at 03:15:55PM +0800, Yong Shen wrote: > >>  move some common functions and micros of mc13783 regulaor driver to >> a seperate file, which makes it possible for mc13892 to share code. > > You'

Re: [PATCHv2] make mc13783 regulator code generic

2010-12-01 Thread Yong Shen
On Wed, Dec 1, 2010 at 3:50 PM, Sascha Hauer wrote: > Hi Yong, > > On Wed, Dec 01, 2010 at 03:15:55PM +0800, Yong Shen wrote: >> Hi there, >> >> This is the v2 with some changes according to comments from v1. There >> will be few patches coming out after this one, for mc13892 regulator >> to share