>
>
> > > > > >
> > > > > > +struct cpu_wp *(*get_cpu_wp)(int *wp);
> > > > > > +
> > > > >
> > > > > This is not needed.
> > > > >
> > > > This is needed, otherwise it does not pass compile.
> > >
> > > This hunk is the only change to arch/arm/mach-mx5/cpu.c and get_cpu_wp
> > > is introduced with
On Mon, Oct 18, 2010 at 05:08:14PM +0800, Yong Shen wrote:
> Hi Sascha,
>
>
> On Mon, Oct 18, 2010 at 4:31 PM, Sascha Hauer wrote:
>
> > Hi Yong,
> >
> > On Mon, Oct 18, 2010 at 01:43:43PM +0800, Yong Shen wrote:
> > > Hi Sascha,
> > >
> > > Thanks for your thorough review. I have two feedbacks
Hi Yong,
On Mon, Oct 18, 2010 at 01:43:43PM +0800, Yong Shen wrote:
> Hi Sascha,
>
> Thanks for your thorough review. I have two feedbacks to your commends.
> Sorry for delayed response, cause I had a hard time due to my computer crash
> and data loss.
>
> > diff --git a/arch/arm/mach-mx5/cpu.c
Hi Sascha,
On Mon, Oct 18, 2010 at 4:31 PM, Sascha Hauer wrote:
> Hi Yong,
>
> On Mon, Oct 18, 2010 at 01:43:43PM +0800, Yong Shen wrote:
> > Hi Sascha,
> >
> > Thanks for your thorough review. I have two feedbacks to your commends.
> > Sorry for delayed response, cause I had a hard time due to
Hi Amit,
I agree about all the comments. New patch is coming.
Yong
On Wed, Oct 13, 2010 at 6:38 PM, Amit Kucheria wrote:
> Yong,
>
> Some more comments. But the patch is looking good now.
>
> On Fri, Oct 8, 2010 at 11:08 AM, wrote:
> > From: Yong Shen
> >
> > it is tested on babbage 3.0
>
>
Hi Sascha,
Thanks for your thorough review. I have two feedbacks to your commends.
Sorry for delayed response, cause I had a hard time due to my computer crash
and data loss.
> diff --git a/arch/arm/mach-mx5/cpu.c b/arch/arm/mach-mx5/cpu.c
> > index 2d37785..83add9c 100644
> > --- a/arch/arm/mach
On Fri, Oct 08, 2010 at 04:08:27PM +0800, yong.s...@linaro.org wrote:
> From: Yong Shen
>
> it is tested on babbage 3.0
>
> Signed-off-by: Yong Shen
> ---
> arch/arm/Kconfig |6 +
> arch/arm/mach-mx5/Kconfig |1 +
> arch/arm/mach-mx5/Makefile
Yong,
Some more comments. But the patch is looking good now.
On Fri, Oct 8, 2010 at 11:08 AM, wrote:
> From: Yong Shen
>
> it is tested on babbage 3.0
Change to
"Cpufreq driver for imx51. The operating points are currently tested
on babbage 3.0."
> Signed-off-by: Yong Shen
> ---
> arch/ar
Does anybody have more comments on [PATCHv2] ?
On Thu, Oct 7, 2010 at 8:00 PM, Yong Shen wrote:
>
> > Using wp_tbl is because that it also contains information like regulator
>> > voltage.
>>
>> The clock code does not handle the regulators, not even in the fsl
>> kernel.
>>
> I did not mean to
From: Yong Shen
it is tested on babbage 3.0
Signed-off-by: Yong Shen
---
arch/arm/Kconfig |6 +
arch/arm/mach-mx5/Kconfig |1 +
arch/arm/mach-mx5/Makefile |1 +
arch/arm/mach-mx5/board-mx51_babbage.c | 12 ++-
arch/arm/mach-mx5/clock
10 matches
Mail list logo