Re: [PATCH v7 2/4] cpufreq: ondemand: call dbs_check_cpu only when necessary

2013-01-31 Thread Viresh Kumar
On 31 January 2013 14:36, Fabio Baltieri wrote: > Current code uses ->cpu to track policy->cpu and get the timestamp, I > can modify it to point to the current cpu and use it in timer_init *and* > add a new field just to track leader_cpu but I don't see the benefits. > Am I missing something? Cur

Re: [PATCH v7 2/4] cpufreq: ondemand: call dbs_check_cpu only when necessary

2013-01-31 Thread Fabio Baltieri
On Thu, Jan 31, 2013 at 02:12:29PM +0530, Viresh Kumar wrote: > On 31 January 2013 14:09, Fabio Baltieri wrote: > > Ok, now I see the problem: cdbs->cpu is initialized only on the leader > > cpu and this is working by coincidence on my system, while > > cdbs->time_stamp is initialized only on the

Re: [PATCH v7 2/4] cpufreq: ondemand: call dbs_check_cpu only when necessary

2013-01-31 Thread Viresh Kumar
On 31 January 2013 14:09, Fabio Baltieri wrote: > Ok, now I see the problem: cdbs->cpu is initialized only on the leader > cpu and this is working by coincidence on my system, while > cdbs->time_stamp is initialized only on the leader cpu, and that should > be correct even when cpu hotplugging as

Re: [PATCH v7 2/4] cpufreq: ondemand: call dbs_check_cpu only when necessary

2013-01-31 Thread Fabio Baltieri
Hello Viresh, On Wed, Jan 30, 2013 at 10:41:08PM +0530, Viresh Kumar wrote: > On 30 January 2013 22:16, Fabio Baltieri wrote: > > Isn't that how it works now? The current cpu ktime is not checked > > against its own, but against the "leader" cpu (dbs_info_local->cdbs.cpu), > > that's why it's in

Re: [PATCH v7 2/4] cpufreq: ondemand: call dbs_check_cpu only when necessary

2013-01-30 Thread Viresh Kumar
On 30 January 2013 22:16, Fabio Baltieri wrote: > Isn't that how it works now? The current cpu ktime is not checked > against its own, but against the "leader" cpu (dbs_info_local->cdbs.cpu), > that's why it's initialized only for the first. > > Maybe I should have used dbs_info_leader/dbs_info i

Re: [PATCH v7 2/4] cpufreq: ondemand: call dbs_check_cpu only when necessary

2013-01-30 Thread Fabio Baltieri
On Wed, Jan 30, 2013 at 09:21:41PM +0530, Viresh Kumar wrote: > On 30 January 2013 18:30, Fabio Baltieri wrote: > > Modify ondemand timer to not resample CPU utilization if recently > > sampled from another SW coordinated core. > > > > Signed-off-by: Fabio Baltieri > > I might be wrong but i hav

Re: [PATCH v7 2/4] cpufreq: ondemand: call dbs_check_cpu only when necessary

2013-01-30 Thread Viresh Kumar
On 30 January 2013 18:30, Fabio Baltieri wrote: > Modify ondemand timer to not resample CPU utilization if recently > sampled from another SW coordinated core. > > Signed-off-by: Fabio Baltieri I might be wrong but i have some real concerns over this patch. This is what i believe is your idea:

[PATCH v7 2/4] cpufreq: ondemand: call dbs_check_cpu only when necessary

2013-01-30 Thread Fabio Baltieri
Modify ondemand timer to not resample CPU utilization if recently sampled from another SW coordinated core. Signed-off-by: Fabio Baltieri --- drivers/cpufreq/cpufreq_governor.c | 3 ++ drivers/cpufreq/cpufreq_governor.h | 1 + drivers/cpufreq/cpufreq_ondemand.c | 58 +++