Re: [PATCH v6 02/11] omap_hsmmc: add support for pre_req and post_req

2011-06-21 Thread Nicolas Pitre
On Tue, 21 Jun 2011, Per Forlin wrote: > On 21 June 2011 21:18, Nicolas Pitre wrote: > > On Tue, 21 Jun 2011, Per Forlin wrote: > > > >> On 21 June 2011 07:41, Kishore Kadiyala > >> wrote: > >> > > >> > > >> >> + > >> >> +static void omap_hsmmc_pre_req(struct mmc_host *mmc, struct > >> >> mmc

Re: [PATCH v6 02/11] omap_hsmmc: add support for pre_req and post_req

2011-06-21 Thread Per Forlin
On 21 June 2011 21:18, Nicolas Pitre wrote: > On Tue, 21 Jun 2011, Per Forlin wrote: > >> On 21 June 2011 07:41, Kishore Kadiyala wrote: >> > >> > >> >> + >> >> +static void omap_hsmmc_pre_req(struct mmc_host *mmc, struct mmc_request >> >> *mrq, >> >> +                              bool is_firs

Re: [PATCH v6 02/11] omap_hsmmc: add support for pre_req and post_req

2011-06-21 Thread Nicolas Pitre
On Tue, 21 Jun 2011, Per Forlin wrote: > On 21 June 2011 07:41, Kishore Kadiyala wrote: > > > > > >> + > >> +static void omap_hsmmc_pre_req(struct mmc_host *mmc, struct mmc_request > >> *mrq, > >> +                              bool is_first_req) > > > > I don't see the usage of "is_first_req"

Re: [PATCH v6 02/11] omap_hsmmc: add support for pre_req and post_req

2011-06-21 Thread Kishore Kadiyala
Hi Per, On Tue, Jun 21, 2011 at 12:21 PM, Per Forlin wrote: > On 21 June 2011 07:41, Kishore Kadiyala wrote: >> >> >>> + >>> +static void omap_hsmmc_pre_req(struct mmc_host *mmc, struct mmc_request >>> *mrq, >>> +                              bool is_first_req) >> >> I don't see the usage of "

Re: [PATCH v6 02/11] omap_hsmmc: add support for pre_req and post_req

2011-06-20 Thread Per Forlin
On 21 June 2011 07:41, Kishore Kadiyala wrote: > > >> + >> +static void omap_hsmmc_pre_req(struct mmc_host *mmc, struct mmc_request >> *mrq, >> +                              bool is_first_req) > > I don't see the usage of "is_first_req" below. > Is it required? > It is not required. It is only

Re: [PATCH v6 02/11] omap_hsmmc: add support for pre_req and post_req

2011-06-20 Thread Kishore Kadiyala
> + > +static void omap_hsmmc_pre_req(struct mmc_host *mmc, struct mmc_request *mrq, > +                              bool is_first_req) I don't see the usage of "is_first_req" below. Is it required? > +{ > +       struct omap_hsmmc_host *host = mmc_priv(mmc); > + > +       if (mrq->data->host_

[PATCH v6 02/11] omap_hsmmc: add support for pre_req and post_req

2011-06-19 Thread Per Forlin
pre_req() runs dma_map_sg(), post_req() runs dma_unmap_sg. If not calling pre_req() before omap_hsmmc_request() dma_map_sg will be issued before starting the transfer. It is optional to use pre_req(). If issuing pre_req() post_req() must be to be called as well. Signed-off-by: Per Forlin --- dri