Re: [PATCH v5 1/9] cpuidle: Add commonly used functionality for consolidation

2012-02-28 Thread Rob Lee
>> Sounds reasonable.  In some cases it may be helpful to track state >> demotion as well.  Since I'm still a noob and wearing my submission >> training wheels, I'm trying to minimize things that fall outside of >> this basic consolidation effort for this patch series.  But I added >> Jon's suggest

Re: [PATCH v5 1/9] cpuidle: Add commonly used functionality for consolidation

2012-02-28 Thread Turquette, Mike
On Tue, Feb 28, 2012 at 3:33 PM, Rob Lee wrote: >> >> I brought this topic up internally and Jon suggested that the 'usage' >> statistics that are reported in sysfs should also reflect failed >> versus successful C-state transitions, which is a great idea.  This >> could simply be achieved by rena

Re: [PATCH v5 1/9] cpuidle: Add commonly used functionality for consolidation

2012-02-28 Thread Rob Lee
> > I brought this topic up internally and Jon suggested that the 'usage' > statistics that are reported in sysfs should also reflect failed > versus successful C-state transitions, which is a great idea.  This > could simply be achieved by renaming the current 'usage' count to > something like 'tr

Re: [PATCH v5 1/9] cpuidle: Add commonly used functionality for consolidation

2012-02-28 Thread Turquette, Mike
On Tue, Feb 28, 2012 at 7:50 AM, Rob Lee wrote: > On Mon, Feb 27, 2012 at 6:49 PM, Turquette, Mike wrote: >> On Sun, Feb 26, 2012 at 8:47 PM, Robert Lee wrote: >>> +/** >>> + * cpuidle_enter_wrap - performing timekeeping and irq around enter >>> function >>> + * @dev: pointer to a valid cpuidle

Re: [PATCH v5 1/9] cpuidle: Add commonly used functionality for consolidation

2012-02-28 Thread Rob Lee
>>> Any reason that this code is in the header?  Why not in cpuidle.c? >>> >> >> Not a strong reason.  I thought making it an inline would introduce >> slightly less new execution when adding this code (realizing that >> there are function calls immediately after, so the only benefit is the >> redu

Re: [PATCH v5 1/9] cpuidle: Add commonly used functionality for consolidation

2012-02-28 Thread Rob Herring
On 02/28/2012 09:45 AM, Rob Lee wrote: > Hey Mike, > > On Mon, Feb 27, 2012 at 6:06 PM, Turquette, Mike wrote: >> On Sun, Feb 26, 2012 at 8:47 PM, Robert Lee wrote: >>> +/** >>> + * cpuidle_enter_wrap - performing timekeeping and irq around enter >>> function >>> + * @dev: pointer to a valid cp

Re: [PATCH v5 1/9] cpuidle: Add commonly used functionality for consolidation

2012-02-28 Thread Rob Lee
On Mon, Feb 27, 2012 at 6:49 PM, Turquette, Mike wrote: > On Sun, Feb 26, 2012 at 8:47 PM, Robert Lee wrote: >> +/** >> + * cpuidle_enter_wrap - performing timekeeping and irq around enter function >> + * @dev: pointer to a valid cpuidle_device object >> + * @drv: pointer to a valid cpuidle_drive

Re: [PATCH v5 1/9] cpuidle: Add commonly used functionality for consolidation

2012-02-28 Thread Rob Lee
Hey Mike, On Mon, Feb 27, 2012 at 6:06 PM, Turquette, Mike wrote: > On Sun, Feb 26, 2012 at 8:47 PM, Robert Lee wrote: >> +/** >> + * cpuidle_enter_wrap - performing timekeeping and irq around enter function >> + * @dev: pointer to a valid cpuidle_device object >> + * @drv: pointer to a valid cp

Re: [PATCH v5 1/9] cpuidle: Add commonly used functionality for consolidation

2012-02-27 Thread Turquette, Mike
On Sun, Feb 26, 2012 at 8:47 PM, Robert Lee wrote: > +/** > + * cpuidle_enter_wrap - performing timekeeping and irq around enter function > + * @dev: pointer to a valid cpuidle_device object > + * @drv: pointer to a valid cpuidle_driver object > + * @index: index of the target cpuidle state. > + *

Re: [PATCH v5 1/9] cpuidle: Add commonly used functionality for consolidation

2012-02-27 Thread Turquette, Mike
On Sun, Feb 26, 2012 at 8:47 PM, Robert Lee wrote: > +/** > + * cpuidle_enter_wrap - performing timekeeping and irq around enter function > + * @dev: pointer to a valid cpuidle_device object > + * @drv: pointer to a valid cpuidle_driver object > + * @index: index of the target cpuidle state. > + *

Re: [PATCH v5 1/9] cpuidle: Add commonly used functionality for consolidation

2012-02-27 Thread Rob Lee
On Mon, Feb 27, 2012 at 10:19 AM, Jean Pihet wrote: > Robert, > > On Mon, Feb 27, 2012 at 5:47 AM, Robert Lee wrote: >> Add functionality that is commonly duplicated by various platforms. >> >> Signed-off-by: Robert Lee >> --- >>  drivers/cpuidle/cpuidle.c |   37 ++ >

Re: [PATCH v5 1/9] cpuidle: Add commonly used functionality for consolidation

2012-02-27 Thread Jean Pihet
Robert, On Mon, Feb 27, 2012 at 5:47 AM, Robert Lee wrote: > Add functionality that is commonly duplicated by various platforms. > > Signed-off-by: Robert Lee > --- >  drivers/cpuidle/cpuidle.c |   37 ++ >  include/linux/cpuidle.h   |   55 > +

[PATCH v5 1/9] cpuidle: Add commonly used functionality for consolidation

2012-02-26 Thread Robert Lee
Add functionality that is commonly duplicated by various platforms. Signed-off-by: Robert Lee --- drivers/cpuidle/cpuidle.c | 37 ++ include/linux/cpuidle.h | 55 + 2 files changed, 77 insertions(+), 15 deletions(-) d