Re: [PATCH v5] usb: gadget: storage: make FSG_NUM_BUFFERS variable size

2011-08-19 Thread Per Forlin
2011/8/19 Michal Nazarewicz : > On Fri, 19 Aug 2011 19:15:32 +0200, Per Forlin > wrote: > >> 2011/8/19 Michal Nazarewicz : >>> >>> On Fri, 19 Aug 2011 16:28:25 +0200, Per Forlin >>> >>> wrote: @@ -3605,6 +3608,9 @@ static int __init fsg_init(void)       int             rc;    

Re: [PATCH v5] usb: gadget: storage: make FSG_NUM_BUFFERS variable size

2011-08-19 Thread Michal Nazarewicz
On Fri, 19 Aug 2011 19:15:32 +0200, Per Forlin wrote: 2011/8/19 Michal Nazarewicz : On Fri, 19 Aug 2011 16:28:25 +0200, Per Forlin wrote: @@ -3605,6 +3608,9 @@ static int __init fsg_init(void) int rc; struct fsg_dev *fsg; + if (!FSG_NUM_BUFFERS_IS_VALID(

Re: [PATCH v5] usb: gadget: storage: make FSG_NUM_BUFFERS variable size

2011-08-19 Thread Per Forlin
2011/8/19 Michal Nazarewicz : > On Fri, 19 Aug 2011 16:28:25 +0200, Per Forlin > wrote: >> >> @@ -3605,6 +3608,9 @@ static int __init fsg_init(void) >>        int             rc; >>        struct fsg_dev  *fsg; >> +       if (!FSG_NUM_BUFFERS_IS_VALID(fsg_num_buffers)) > > Care to add pr_err() her

Re: [PATCH v5] usb: gadget: storage: make FSG_NUM_BUFFERS variable size

2011-08-19 Thread Michal Nazarewicz
On Fri, 19 Aug 2011 16:28:25 +0200, Per Forlin wrote: @@ -3605,6 +3608,9 @@ static int __init fsg_init(void) int rc; struct fsg_dev *fsg; + if (!FSG_NUM_BUFFERS_IS_VALID(fsg_num_buffers)) Care to add pr_err() here? Or better yet, change fsg_num_buffers_is

Re: [PATCH v5] usb: gadget: storage: make FSG_NUM_BUFFERS variable size

2011-08-19 Thread Per Forlin
On 19 August 2011 16:28, Per Forlin wrote: > From: Per Forlin > > FSG_NUM_BUFFERS is set to 2 as default. > Usually 2 buffers are enough to establish a good buffering pipeline. > The number may be increased in order to compensate a for bursty VFS > behaviour. > > Here follows a description of sys

[PATCH v5] usb: gadget: storage: make FSG_NUM_BUFFERS variable size

2011-08-19 Thread Per Forlin
From: Per Forlin FSG_NUM_BUFFERS is set to 2 as default. Usually 2 buffers are enough to establish a good buffering pipeline. The number may be increased in order to compensate a for bursty VFS behaviour. Here follows a description of system that may require more than 2 buffers. * CPU ondemand