Re: [PATCH v4 3/7] ARM: imx: clean and consolidate imx5 suspend and idle code

2012-05-17 Thread Sascha Hauer
On Thu, May 17, 2012 at 09:34:26AM -0500, Rob Lee wrote: > On Wed, May 16, 2012 at 12:38 PM, Sascha Hauer wrote: > > Hi Robert, > > > > Overall this looks ok now, some comments inline. > > > >> +             return ret; > >> + > >> +     if (cpu_is_mx51()) > >> +             suspend_set_ops(&mx5_s

Re: [PATCH v4 3/7] ARM: imx: clean and consolidate imx5 suspend and idle code

2012-05-17 Thread Rob Lee
On Wed, May 16, 2012 at 12:38 PM, Sascha Hauer wrote: > Hi Robert, > > Overall this looks ok now, some comments inline. > > Sascha > > On Tue, May 15, 2012 at 09:33:32PM -0500, Robert Lee wrote: >> The imx5 idle code that existed in mm-imx5.c is moved to pm-imx5.c. >> The imx5_pm_init call is now

Re: [PATCH v4 3/7] ARM: imx: clean and consolidate imx5 suspend and idle code

2012-05-16 Thread Sascha Hauer
Hi Robert, Overall this looks ok now, some comments inline. Sascha On Tue, May 15, 2012 at 09:33:32PM -0500, Robert Lee wrote: > The imx5 idle code that existed in mm-imx5.c is moved to pm-imx5.c. > The imx5_pm_init call is now exported and called during the > MACHINE_START late_init in supporte

[PATCH v4 3/7] ARM: imx: clean and consolidate imx5 suspend and idle code

2012-05-15 Thread Robert Lee
The imx5 idle code that existed in mm-imx5.c is moved to pm-imx5.c. The imx5_pm_init call is now exported and called during the MACHINE_START late_init in supported imx5 platforms. Remove various enabling/disabling of the gpc_dvfs clock and enable it once during initialization. This is a very low