Re: [PATCH v4 2/2] Regulator: Add Anatop regulator driver

2012-02-11 Thread Mark Brown
On Fri, Feb 10, 2012 at 10:36:38PM -0800, Shawn Guo wrote: > On Thu, Feb 09, 2012 at 04:51:26AM +0800, Ying-Chun Liu (PaulLiu) wrote: > > + rval = of_get_property(np, "min-voltage", NULL); > > + if (rval) > > + sreg->rdata->min_voltage = be32_to_cpu(*rval); > > + rval = of_get_prop

Re: [PATCH v4 2/2] Regulator: Add Anatop regulator driver

2012-02-10 Thread Shawn Guo
On Thu, Feb 09, 2012 at 04:51:26AM +0800, Ying-Chun Liu (PaulLiu) wrote: > From: "Ying-Chun Liu (PaulLiu)" > > Anatop is an integrated regulator inside i.MX6 SoC. > There are 3 digital regulators which controls PU, CORE (ARM), and SOC. > And 3 analog regulators which controls 1P1, 2P5, 3P0 (USB).

Re: [PATCH v4 2/2] Regulator: Add Anatop regulator driver

2012-02-09 Thread Mark Brown
On Thu, Feb 09, 2012 at 04:51:26AM +0800, Ying-Chun Liu (PaulLiu) wrote: Overall this is looking pretty good, a few issues but relatively minor. > + if (uv < anatop_reg->rdata->min_voltage > + || uv > anatop_reg->rdata->max_voltage) { > + if (max_uV > anatop_reg->rdata->mi

[PATCH v4 2/2] Regulator: Add Anatop regulator driver

2012-02-08 Thread Ying-Chun Liu (PaulLiu)
From: "Ying-Chun Liu (PaulLiu)" Anatop is an integrated regulator inside i.MX6 SoC. There are 3 digital regulators which controls PU, CORE (ARM), and SOC. And 3 analog regulators which controls 1P1, 2P5, 3P0 (USB). This patch adds the Anatop regulator driver. Signed-off-by: Nancy Chen Signed-of