Re: [PATCH v2 6/7] clk: Add initial WM831x clock driver

2011-10-04 Thread Grant Likely
On Tue, Oct 04, 2011 at 09:50:02PM +0100, Mark Brown wrote: > On Tue, Oct 04, 2011 at 12:18:18PM -0600, Grant Likely wrote: > > #define module_platform_driver(__driver) \ > > int __driver##_init(void) \ > > { \ > > return platform_driver_register(&(__driver)); \ > > } \ > > module_init(__driver

Re: [PATCH v2 6/7] clk: Add initial WM831x clock driver

2011-10-04 Thread Mark Brown
On Tue, Oct 04, 2011 at 12:18:18PM -0600, Grant Likely wrote: > On Mon, Sep 26, 2011 at 10:38:58AM +0100, Mark Brown wrote: > > No, that's not helpful. The issue isn't the device probe code itself, > > the issue is things like module unload not doing what they're supposed > > to do and leaving th

Re: [PATCH v2 6/7] clk: Add initial WM831x clock driver

2011-10-04 Thread Grant Likely
On Mon, Sep 26, 2011 at 10:38:58AM +0100, Mark Brown wrote: > On Sat, Sep 24, 2011 at 10:08:36PM -0600, Grant Likely wrote: > > On Thu, Sep 22, 2011 at 03:27:01PM -0700, Mike Turquette wrote: > > > > + ret = platform_driver_register(&wm831x_clk_driver); > > > + if (ret != 0) > > > + pr_err

Re: [PATCH v2 6/7] clk: Add initial WM831x clock driver

2011-09-26 Thread Mark Brown
On Sat, Sep 24, 2011 at 10:08:36PM -0600, Grant Likely wrote: > On Thu, Sep 22, 2011 at 03:27:01PM -0700, Mike Turquette wrote: > > + ret = platform_driver_register(&wm831x_clk_driver); > > + if (ret != 0) > > + pr_err("Failed to register WM831x clock driver: %d\n", ret); > > + > > +

Re: [PATCH v2 6/7] clk: Add initial WM831x clock driver

2011-09-24 Thread Turquette, Mike
On Sat, Sep 24, 2011 at 9:08 PM, Grant Likely wrote: > On Thu, Sep 22, 2011 at 03:27:01PM -0700, Mike Turquette wrote: >> From: Mark Brown >> >> The WM831x and WM832x series of PMICs contain a flexible clocking >> subsystem intended to provide always on and system core clocks.  It >> features: >>

Re: [PATCH v2 6/7] clk: Add initial WM831x clock driver

2011-09-24 Thread Grant Likely
On Thu, Sep 22, 2011 at 03:27:01PM -0700, Mike Turquette wrote: > From: Mark Brown > > The WM831x and WM832x series of PMICs contain a flexible clocking > subsystem intended to provide always on and system core clocks. It > features: > > - A 32.768kHz crystal oscillator which can optionally be

[PATCH v2 6/7] clk: Add initial WM831x clock driver

2011-09-22 Thread Mike Turquette
From: Mark Brown The WM831x and WM832x series of PMICs contain a flexible clocking subsystem intended to provide always on and system core clocks. It features: - A 32.768kHz crystal oscillator which can optionally be used to pass through an externally generated clock. - A FLL which can be clo