On Wed, May 02, 2012 at 02:16:36PM -0500, Rob Lee wrote:
> Sascha,
>
> >> +int __init imx_cpuidle_init(struct cpuidle_driver *drv)
> >> +{
> >> + struct cpuidle_device *dev;
> >> + int cpu_id, ret;
> >> +
> >> + if (!drv || drv->state_count > CPUIDLE_STATE_MAX) {
> >
> > Please don't c
Sascha,
On Wed, May 2, 2012 at 2:27 AM, Sascha Hauer wrote:
> On Tue, May 01, 2012 at 09:12:38PM -0500, Robert Lee wrote:
>> Add common cpuidle init functionality that can be used by various
>> imx platforms.
>>
>> Signed-off-by: Robert Lee
>> ---
>> +
>> +int __init imx_cpuidle_init(struct cpui
On Wed, May 2, 2012 at 9:07 AM, Shawn Guo wrote:
> On 2 May 2012 21:59, Rob Lee wrote:
+ ret = cpuidle_register_device(dev);
+ if (ret) {
+ pr_err("%s: Failed to register cpu %u\n",
+ __func__, cpu_id);
>>
On 2 May 2012 21:59, Rob Lee wrote:
>>> + ret = cpuidle_register_device(dev);
>>> + if (ret) {
>>> + pr_err("%s: Failed to register cpu %u\n",
>>> + __func__, cpu_id);
>>
>> Nit: print ret (error code) too?
>>
>
> I added the
Shawn,
On Tue, May 1, 2012 at 10:13 PM, Shawn Guo wrote:
> On Tue, May 01, 2012 at 09:12:38PM -0500, Robert Lee wrote:
>> Add common cpuidle init functionality that can be used by various
>> imx platforms.
>>
>> Signed-off-by: Robert Lee
>> ---
>> arch/arm/plat-mxc/Makefile | 1
On Tue, May 01, 2012 at 09:12:38PM -0500, Robert Lee wrote:
> Add common cpuidle init functionality that can be used by various
> imx platforms.
>
> Signed-off-by: Robert Lee
> ---
> +
> +int __init imx_cpuidle_init(struct cpuidle_driver *drv)
> +{
> + struct cpuidle_device *dev;
> + int
On Tue, May 01, 2012 at 09:12:38PM -0500, Robert Lee wrote:
> Add common cpuidle init functionality that can be used by various
> imx platforms.
>
> Signed-off-by: Robert Lee
> ---
> arch/arm/plat-mxc/Makefile |1 +
> arch/arm/plat-mxc/cpuidle.c | 80
> +
Add common cpuidle init functionality that can be used by various
imx platforms.
Signed-off-by: Robert Lee
---
arch/arm/plat-mxc/Makefile |1 +
arch/arm/plat-mxc/cpuidle.c | 80 ++
arch/arm/plat-mxc/include/mach/cpuidle.h | 22 ++
