Re: [PATCH V4 1/5] arm/dt: add basic mx51 device tree support

2011-03-17 Thread Grant Likely
On Thu, Mar 17, 2011 at 09:54:35AM +0800, Shawn Guo wrote: > On Tue, Mar 15, 2011 at 01:03:42AM -0600, Grant Likely wrote: > > > +#ifdef CONFIG_OF > > > +static struct clk *mx5_dt_clk_get(struct device_node *np, > > > + const char *output_id, void *data) > > > +{ > >

Re: [PATCH V4 1/5] arm/dt: add basic mx51 device tree support

2011-03-16 Thread Shawn Guo
On Tue, Mar 15, 2011 at 01:03:42AM -0600, Grant Likely wrote: > Hi Jason, > > Minor comments below. > > On Thu, Mar 10, 2011 at 12:59:41PM +0800, Jason Liu wrote: > > Signed-off-by: Jason Liu > > Signed-off-by: Jason Liu > > This looks wrong. You should only have one s-o-b line. Use one emai

Re: [PATCH V4 1/5] arm/dt: add basic mx51 device tree support

2011-03-16 Thread Paul E. McKenney
On Tue, Mar 15, 2011 aFt 11:03:55PM -0600, Grant Likely wrote: > On Tue, Mar 15, 2011 at 9:34 PM, Jason Hui wrote: > > Hi, Grant, > > > > On Tue, Mar 15, 2011 at 3:03 PM, Grant Likely > > wrote: > >> Hi Jason, > >> > >> Minor comments below. > >> > >> On Thu, Mar 10, 2011 at 12:59:41PM +0800, Ja

Re: [PATCH V4 1/5] arm/dt: add basic mx51 device tree support

2011-03-15 Thread Grant Likely
On Tue, Mar 15, 2011 at 9:34 PM, Jason Hui wrote: > Hi, Grant, > > On Tue, Mar 15, 2011 at 3:03 PM, Grant Likely > wrote: >> Hi Jason, >> >> Minor comments below. >> >> On Thu, Mar 10, 2011 at 12:59:41PM +0800, Jason Liu wrote: >>> Signed-off-by: Jason Liu >>> Signed-off-by: Jason Liu >> >> Th

Re: [PATCH V4 1/5] arm/dt: add basic mx51 device tree support

2011-03-15 Thread Jason Hui
Hi, Grant, On Tue, Mar 15, 2011 at 3:03 PM, Grant Likely wrote: > Hi Jason, > > Minor comments below. > > On Thu, Mar 10, 2011 at 12:59:41PM +0800, Jason Liu wrote: >> Signed-off-by: Jason Liu >> Signed-off-by: Jason Liu > > This looks wrong.  You should only have one s-o-b line.  Use one email

Re: [PATCH V4 1/5] arm/dt: add basic mx51 device tree support

2011-03-15 Thread Grant Likely
Hi Jason, Minor comments below. On Thu, Mar 10, 2011 at 12:59:41PM +0800, Jason Liu wrote: > Signed-off-by: Jason Liu > Signed-off-by: Jason Liu This looks wrong. You should only have one s-o-b line. Use one email addr or the other. Not both. > --- > arch/arm/mach-mx5/Kconfig

[PATCH V4 1/5] arm/dt: add basic mx51 device tree support

2011-03-09 Thread Jason Liu
Signed-off-by: Jason Liu Signed-off-by: Jason Liu --- arch/arm/mach-mx5/Kconfig |8 arch/arm/mach-mx5/Makefile |1 + arch/arm/mach-mx5/board-dt.c| 65 +++ arch/arm/mach-mx5/clock-mx51-mx53.c | 43