Re: [PATCH V2 5/6] USB: OHCI: make ohci-at91 a separate driver

2013-06-22 Thread Manjunath Goudar
On 23 June 2013 00:38, Alan Stern wrote: > On Sun, 23 Jun 2013, Manjunath Goudar wrote: > > > > As a general rule, you should never change code that you don't > > > understand. Do you _know_ that it will be safe to call ohci_setup() or > > > ohci_restart() at this point? > > > > > > > > From Dav

Re: [PATCH V2 5/6] USB: OHCI: make ohci-at91 a separate driver

2013-06-22 Thread Alan Stern
On Sun, 23 Jun 2013, Manjunath Goudar wrote: > > As a general rule, you should never change code that you don't > > understand. Do you _know_ that it will be safe to call ohci_setup() or > > ohci_restart() at this point? > > > > > From David Brownell comment I am understanding,instead of calling

Re: [PATCH V2 5/6] USB: OHCI: make ohci-at91 a separate driver

2013-06-22 Thread Manjunath Goudar
On 21 June 2013 22:03, Alan Stern wrote: > On Fri, 21 Jun 2013, Manjunath Goudar wrote: > > > On 20 June 2013 22:23, Alan Stern wrote: > > > > > On Thu, 20 Jun 2013, Manjunath Goudar wrote: > > > > > > > > > @@ -686,7 +631,7 @@ ohci_hcd_at91_drv_suspend(struct > platform_device > > > > > *pdev,

Re: [PATCH V2 5/6] USB: OHCI: make ohci-at91 a separate driver

2013-06-21 Thread Alan Stern
On Fri, 21 Jun 2013, Manjunath Goudar wrote: > On 20 June 2013 22:23, Alan Stern wrote: > > > On Thu, 20 Jun 2013, Manjunath Goudar wrote: > > > > > > > @@ -686,7 +631,7 @@ ohci_hcd_at91_drv_suspend(struct platform_device > > > > *pdev, pm_message_t mesg) > > > > >* REVISIT: some boards

Re: [PATCH V2 5/6] USB: OHCI: make ohci-at91 a separate driver

2013-06-21 Thread Manjunath Goudar
On 20 June 2013 22:23, Alan Stern wrote: > On Thu, 20 Jun 2013, Manjunath Goudar wrote: > > > > > @@ -686,7 +631,7 @@ ohci_hcd_at91_drv_suspend(struct platform_device > > > *pdev, pm_message_t mesg) > > > >* REVISIT: some boards will be able to turn VBUS off... > > > >*/ > > > >

Re: [PATCH V2 5/6] USB: OHCI: make ohci-at91 a separate driver

2013-06-20 Thread Alan Stern
On Thu, 20 Jun 2013, Manjunath Goudar wrote: > > > @@ -686,7 +631,7 @@ ohci_hcd_at91_drv_suspend(struct platform_device > > *pdev, pm_message_t mesg) > > >* REVISIT: some boards will be able to turn VBUS off... > > >*/ > > > if (at91_suspend_entering_slow_clock()) { > > > -

Re: [PATCH V2 5/6] USB: OHCI: make ohci-at91 a separate driver

2013-06-20 Thread Manjunath Goudar
On 20 June 2013 01:46, Alan Stern wrote: > On Wed, 12 Jun 2013, Manjunath Goudar wrote: > > > Separate the TI OHCI Atmel host controller driver from ohci-hcd > > host code so that it can be built as a separate driver module. > > This work is part of enabling multi-platform kernels on ARM; > > it

Re: [PATCH V2 5/6] USB: OHCI: make ohci-at91 a separate driver

2013-06-19 Thread Alan Stern
On Wed, 12 Jun 2013, Manjunath Goudar wrote: > Separate the TI OHCI Atmel host controller driver from ohci-hcd > host code so that it can be built as a separate driver module. > This work is part of enabling multi-platform kernels on ARM; > it would be nice to have in 3.11. > > V2: > -Set non-s

[PATCH V2 5/6] USB: OHCI: make ohci-at91 a separate driver

2013-06-12 Thread Manjunath Goudar
Separate the TI OHCI Atmel host controller driver from ohci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM; it would be nice to have in 3.11. V2: -Set non-standard fields in ohci_at91_hc_driver manually, rather than