Re: [PATCH V2 01/10] USB: OHCI: Properly handle ohci-at91 suspend

2013-06-17 Thread Manjunath Goudar
On 17 June 2013 14:55, Viresh Kumar wrote: > On 17 June 2013 14:52, Manjunath Goudar > wrote: > > when we are using tab characters before "do_wakeup" and "ret" > variable,we > > will be getting error below. > > > > WARNING: please, no space before tabs > > #31: FILE: drivers/usb/host/ohci-at91.

Re: [PATCH V2 01/10] USB: OHCI: Properly handle ohci-at91 suspend

2013-06-17 Thread Manjunath Goudar
On 14 June 2013 00:44, Alan Stern wrote: > On Thu, 13 Jun 2013, Manjunath Goudar wrote: > > > Suspend scenario in case of ohci-at91 glue was not properly > > handled as it was not suspending generic part of ohci controller. > > Calling explicitly the ohci_suspend() routine in > ohci_hcd_at91_drv_

Re: [PATCH V2 01/10] USB: OHCI: Properly handle ohci-at91 suspend

2013-06-17 Thread Viresh Kumar
On 17 June 2013 14:52, Manjunath Goudar wrote: > when we are using tab characters before "do_wakeup" and "ret" variable,we > will be getting error below. > > WARNING: please, no space before tabs > #31: FILE: drivers/usb/host/ohci-at91.c:622: > +^Ibool ^I^Ido_wakeup = device_may_wakeup(&pdev->dev

Re: [PATCH V2 01/10] USB: OHCI: Properly handle ohci-at91 suspend

2013-06-13 Thread Alan Stern
On Thu, 13 Jun 2013, Manjunath Goudar wrote: > Suspend scenario in case of ohci-at91 glue was not properly > handled as it was not suspending generic part of ohci controller. > Calling explicitly the ohci_suspend() routine in ohci_hcd_at91_drv_suspend() > will ensure proper handling of suspend sce

[PATCH V2 01/10] USB: OHCI: Properly handle ohci-at91 suspend

2013-06-13 Thread Manjunath Goudar
Suspend scenario in case of ohci-at91 glue was not properly handled as it was not suspending generic part of ohci controller. Calling explicitly the ohci_suspend() routine in ohci_hcd_at91_drv_suspend() will ensure proper handling of suspend scenario. V2: -Incase ohci_suspend() fails, return rig