Re: [PATCH RFC 1/2] PM / Hibernate: use name_to_dev_t to parse resume

On Tue 2013-09-17 13:50:21, Sebastian Capella wrote: > Quoting Sebastian Capella (2013-08-30 11:42:30) > > Quoting Pavel Machek (2013-08-30 04:35:33) > > > On Mon 2013-08-26 10:40:50, Sebastian Capella wrote: > > > > Quoting Pavel Machek (2013-08-25 08:38:11) > > > > > Is the allocation actually ne

Re: [PATCH RFC 1/2] PM / Hibernate: use name_to_dev_t to parse resume

Quoting Sebastian Capella (2013-08-30 11:42:30) > Quoting Pavel Machek (2013-08-30 04:35:33) > > On Mon 2013-08-26 10:40:50, Sebastian Capella wrote: > > > Quoting Pavel Machek (2013-08-25 08:38:11) > > > > Is the allocation actually neccessary? At the very least this should > > > > test for NULL..

Re: [PATCH RFC 1/2] PM / Hibernate: use name_to_dev_t to parse resume

Quoting Pavel Machek (2013-08-30 04:35:33) > On Mon 2013-08-26 10:40:50, Sebastian Capella wrote: > > Quoting Pavel Machek (2013-08-25 08:38:11) > > > Is the allocation actually neccessary? At the very least this should > > > test for NULL... > > > > name_to_dev_t expects a non-const name, but the

Re: [PATCH RFC 1/2] PM / Hibernate: use name_to_dev_t to parse resume

On Mon 2013-08-26 10:40:50, Sebastian Capella wrote: > Apologies for my previous top post reply... > > Quoting Pavel Machek (2013-08-25 08:38:11) > > Is the allocation actually neccessary? At the very least this should > > test for NULL... > > > Thanks Pavel! I'll add the check for NULL. > > n

Re: [PATCH RFC 1/2] PM / Hibernate: use name_to_dev_t to parse resume

Apologies for my previous top post reply... Quoting Pavel Machek (2013-08-25 08:38:11) > Is the allocation actually neccessary? At the very least this should > test for NULL... Thanks Pavel! I'll add the check for NULL. name_to_dev_t expects a non-const name, but the buffer passed in is const.

Re: [PATCH RFC 1/2] PM / Hibernate: use name_to_dev_t to parse resume

Thanks Pavel! I'll add the check for NULL. name_to_dev_t expects a non-const name, but the buffer passed in is const. I also am removing the '\n' if found at the end of the string which would violate the const. Thanks! Sebastian On 25 August 2013 08:38, Pavel Machek wrote: > Hi! > > > Use t

Re: [PATCH RFC 1/2] PM / Hibernate: use name_to_dev_t to parse resume

Hi! > Use the name_to_dev_t call to parse the device name echo'd to > to /sys/power/resume. This imitates the method used in hibernate.c > in software_resume, and allows the resume partition to be specified > using other equivalent device formats as well. By allowing > /sys/debug/resume to accep

[PATCH RFC 1/2] PM / Hibernate: use name_to_dev_t to parse resume

Use the name_to_dev_t call to parse the device name echo'd to to /sys/power/resume. This imitates the method used in hibernate.c in software_resume, and allows the resume partition to be specified using other equivalent device formats as well. By allowing /sys/debug/resume to accept the same synt