Re: [PATCH Ceph] crc32c: add arm64/aarch64 optimized crc32c implementation

2015-01-22 Thread Yazen Ghannam
On Thu, Jan 22, 2015 at 4:58 AM, Steve Capper wrote: > Hi Yazen, > > I have a few comments below. > > Cheers, > -- > Steve > > > On Wed, Jan 21, 2015 at 02:17:47PM -0600, Yazen Ghannam wrote: >> Tested on AMD Seattle. >> Passes all crc32c unit tests. >> ~4x performance increase versus sctp. > > Wa

Re: [PATCH Ceph] crc32c: add arm64/aarch64 optimized crc32c implementation

2015-01-22 Thread Steve Capper
Hi Yazen, I have a few comments below. Cheers, -- Steve On Wed, Jan 21, 2015 at 02:17:47PM -0600, Yazen Ghannam wrote: > Tested on AMD Seattle. > Passes all crc32c unit tests. > ~4x performance increase versus sctp. Was that perf result from the unit test? Also describe the reason for the pa

[PATCH Ceph] crc32c: add arm64/aarch64 optimized crc32c implementation

2015-01-21 Thread Yazen Ghannam
Tested on AMD Seattle. Passes all crc32c unit tests. ~4x performance increase versus sctp. Signed-off-by: Yazen Ghannam --- configure.ac | 1 + m4/ax_arm.m4 | 18 +--- src/arch/arm.c | 2 ++ src/arch/arm.h | 1 +