On Fri, Jun 24, 2011 at 6:27 AM, Thomas Abraham
wrote:
> Hi Grant,
>
> On 24 June 2011 01:38, Grant Likely wrote:
>> Despite the fact that this is exactly what I asked you to write, this
>> ends up being rather ugly. (I originally put in the '*4' to match the
>> behaviour of the existing of_read
Hi Grant,
On 24 June 2011 01:38, Grant Likely wrote:
> Despite the fact that this is exactly what I asked you to write, this
> ends up being rather ugly. (I originally put in the '*4' to match the
> behaviour of the existing of_read_number(), but that was a mistake.
> tglx also pointed it out).
On Wed, Jun 22, 2011 at 10:22 AM, Thomas Abraham
wrote:
>
> I have added the functions as you have suggested and the diff is
> listed below. Could you please review the diff and suggest any changes
> required.
Thanks Thomas. Comments below...
> drivers/of/base.c | 129
>
Hi Grant,
On 20 June 2011 22:13, Grant Likely wrote:
> Okay, this is getting ugly (not your fault, but this pattern has
> become too common. Can you craft and post a patch that adds the
> following functions to drivers/of/base.c and include/linux/of.h
>
> /* offset in cells, not bytes */
> int d
On Mon, Jun 20, 2011 at 10:43:50AM -0600, Grant Likely wrote:
> I think I've commented on this before, but I do try to avoid direct
> coding registers into the DT. That said, sometimes there really isn't
> a nice human-friendly way of encoding things and direct register
> values is the best appro
Hi Grant,
On 20 June 2011 22:13, Grant Likely wrote:
>
> For custom properties, you should prefix the property name with 'samsung,'.
>
> This looks very much like directly encoding the Linux flags into the
> device tree. The binding should be completely contained within
> itself, and not refer t
On Mon, Jun 20, 2011 at 5:02 AM, Thomas Abraham
wrote:
> For device tree based probe, the dependecy on pdev->id to attach a
> corresponding default port info to the driver's private data is
> removed. The fifosize parameter is obtained from the device tree
> node and the next available instance of
For device tree based probe, the dependecy on pdev->id to attach a
corresponding default port info to the driver's private data is
removed. The fifosize parameter is obtained from the device tree
node and the next available instance of port info is updated
with the fifosize value and attached to th
