Re: [PATCH 2/4 v6] pinmux: add a driver for the U300 pinmux

2011-09-13 Thread Barry Song
2011/9/13 Linus Walleij : > On Fri, Sep 2, 2011 at 6:04 PM, Stephen Warren wrote: >> Linus Walleij wrote at Friday, September 02, 2011 2:12 AM: >>> On Thu, Sep 1, 2011 at 11:33 PM, Stephen Warren wrote: >>> >>> >> +static const struct u300_pmx_func u300_pmx_functions[] = { >>> >> +     { >>> >> +

Re: [PATCH 2/4 v6] pinmux: add a driver for the U300 pinmux

2011-09-13 Thread Linus Walleij
On Fri, Sep 2, 2011 at 6:04 PM, Stephen Warren wrote: > Linus Walleij wrote at Friday, September 02, 2011 2:12 AM: >> On Thu, Sep 1, 2011 at 11:33 PM, Stephen Warren wrote: >> >> >> +static const struct u300_pmx_func u300_pmx_functions[] = { >> >> +     { >> >> +             .name = "power", >> >

RE: [PATCH 2/4 v6] pinmux: add a driver for the U300 pinmux

2011-09-02 Thread Stephen Warren
Linus Walleij wrote at Friday, September 02, 2011 2:12 AM: > On Thu, Sep 1, 2011 at 11:33 PM, Stephen Warren wrote: > > >> +static const struct u300_pmx_func u300_pmx_functions[] = { > >> +     { > >> +             .name = "power", > >> +             .groups = { POWERGRP_INDEX }, > >> +          

Re: [PATCH 2/4 v6] pinmux: add a driver for the U300 pinmux

2011-09-02 Thread Linus Walleij
On Thu, Sep 1, 2011 at 11:33 PM, Stephen Warren wrote: >> +static const struct u300_pmx_func u300_pmx_functions[] = { >> +     { >> +             .name = "power", >> +             .groups = { POWERGRP_INDEX }, >> +             /* Mask is N/A */ >> +     }, > > Hmmm. That's a lot of _INDEX defines

RE: [PATCH 2/4 v6] pinmux: add a driver for the U300 pinmux

2011-09-01 Thread Stephen Warren
Linus Walleij wrote at Thursday, September 01, 2011 3:33 AM: > This adds a driver for the U300 pinmux portions of the system > controller "SYSCON". It also serves as an example of how to use > the pinmux subsystem. This driver also houses the platform data > for the only supported platform. > diff

[PATCH 2/4 v6] pinmux: add a driver for the U300 pinmux

2011-09-01 Thread Linus Walleij
From: Linus Walleij This adds a driver for the U300 pinmux portions of the system controller "SYSCON". It also serves as an example of how to use the pinmux subsystem. This driver also houses the platform data for the only supported platform. Signed-off-by: Linus Walleij --- ChangeLog v5->v6: