On 20 June 2012 15:04, hongbo.zhang wrote:
> From: "hongbo.zhang"
>
> ---
> arch/arm/configs/u8500_defconfig |4 +
> arch/arm/mach-ux500/board-mop500.c | 71
> drivers/thermal/Kconfig | 16 +
> drivers/thermal/Makefile |
I sent the mail before finishing the review. additional one will come soon
On 5 July 2012 16:13, Vincent Guittot wrote:
> On 20 June 2012 15:04, hongbo.zhang wrote:
>> From: "hongbo.zhang"
>>
>> ---
>> arch/arm/configs/u8500_defconfig |4 +
>> arch/arm/mach-ux500/board-mop500.c
On 20 June 2012 15:04, hongbo.zhang wrote:
> From: "hongbo.zhang"
>
> ---
> arch/arm/configs/u8500_defconfig |4 +
> arch/arm/mach-ux500/board-mop500.c | 71
> drivers/thermal/Kconfig | 16 +
> drivers/thermal/Makefile |
On 5 July 2012 07:20, Linus Walleij wrote:
> On Wed, Jun 20, 2012 at 3:04 PM, hongbo.zhang
> wrote:
>
> > /*
> > + * Thermal Sensor
> > + */
> > +
> > +#ifdef CONFIG_DB8500_THERMAL
>
> Please don't #ifdef the platform data like this, Documentation/CodingStyle
> dislikes #ifdefs unless needed an
On Wed, Jun 20, 2012 at 3:04 PM, hongbo.zhang wrote:
> /*
> + * Thermal Sensor
> + */
> +
> +#ifdef CONFIG_DB8500_THERMAL
Please don't #ifdef the platform data like this, Documentation/CodingStyle
dislikes #ifdefs unless needed and this just saves a very marginal piece of
code in footprint, and
From: "hongbo.zhang"
---
arch/arm/configs/u8500_defconfig |4 +
arch/arm/mach-ux500/board-mop500.c | 71
drivers/thermal/Kconfig | 16 +
drivers/thermal/Makefile |4 +-
drivers/thermal/cpu_cooling.c|
