Re: [PATCH 1/3] ARM: omap_device: handle first time activation of console device

2011-11-17 Thread Rajendra Nayak
[]... Why do we have to idle -> enable? The module is already enabled, isn't it? The comment is not super clear for me :-) Is the goal is to reset the IP? Yes, now that I read it, it does sound confusing. I should have at-least read it once before I picked it from serial.c But anyway, here's

Re: [PATCH 1/3] ARM: omap_device: handle first time activation of console device

2011-11-17 Thread Cousson, Benoit
Hi Rajendra, On 11/17/2011 8:19 AM, Rajendra Nayak wrote: [...] +static int omap_console_hwmod_enable(struct omap_device *od) +{ + console_lock(); + /* + * For early console we prevented hwmod reset and idle A period is missing. Or maybe it should a comma with not capital letter. + * So bef

Re: [PATCH 1/3] ARM: omap_device: handle first time activation of console device

2011-11-16 Thread Rajendra Nayak
Hi Rob, On Wednesday 16 November 2011 08:20 PM, Rob Herring wrote: []... diff --git a/Documentation/devicetree/bindings/arm/omap/omap.txt b/Documentation/devicetree/bindings/arm/omap/omap.txt index dbdab40..46ffd41 100644 --- a/Documentation/devicetree/bindings/arm/omap/omap.txt +++ b/Document

Re: [PATCH 1/3] ARM: omap_device: handle first time activation of console device

2011-11-16 Thread Rajendra Nayak
[...] +static int omap_console_hwmod_enable(struct omap_device *od) +{ + console_lock(); + /* +* For early console we prevented hwmod reset and idle A period is missing. Or maybe it should a comma with not capital letter. +* So before we enable the uart clocks idle

Re: [PATCH 1/3] ARM: omap_device: handle first time activation of console device

2011-11-16 Thread Cousson, Benoit
On 11/16/2011 4:41 PM, Rob Herring wrote: Benoit, On 11/16/2011 09:14 AM, Cousson, Benoit wrote: Hi Rob, On 11/16/2011 3:50 PM, Rob Herring wrote: On 11/16/2011 05:02 AM, Rajendra Nayak wrote: console device on OMAP is never reset or idled by hwmod post initial setup, early during boot, for

Re: [PATCH 1/3] ARM: omap_device: handle first time activation of console device

2011-11-16 Thread Rob Herring
Benoit, On 11/16/2011 09:14 AM, Cousson, Benoit wrote: > Hi Rob, > > On 11/16/2011 3:50 PM, Rob Herring wrote: >> On 11/16/2011 05:02 AM, Rajendra Nayak wrote: >>> console device on OMAP is never reset or idled by hwmod post >>> initial setup, early during boot, for obvious reasons not to >>> bre

Re: [PATCH 1/3] ARM: omap_device: handle first time activation of console device

2011-11-16 Thread Cousson, Benoit
Hi Rob, On 11/16/2011 3:50 PM, Rob Herring wrote: On 11/16/2011 05:02 AM, Rajendra Nayak wrote: console device on OMAP is never reset or idled by hwmod post initial setup, early during boot, for obvious reasons not to break early debug prints thrown on console. This leaves the console device en

Re: [PATCH 1/3] ARM: omap_device: handle first time activation of console device

2011-11-16 Thread Cousson, Benoit
Hi Rajendra, On 11/16/2011 12:02 PM, Rajendra Nayak wrote: > console device on OMAP is never reset or idled by hwmod post > initial setup, early during boot, for obvious reasons not to > break early debug prints thrown on console. > This leaves the console device enabled at boot and the first acti

Re: [PATCH 1/3] ARM: omap_device: handle first time activation of console device

2011-11-16 Thread Rob Herring
On 11/16/2011 05:02 AM, Rajendra Nayak wrote: > console device on OMAP is never reset or idled by hwmod post > initial setup, early during boot, for obvious reasons not to > break early debug prints thrown on console. > This leaves the console device enabled at boot and the first activation > of it

[PATCH 1/3] ARM: omap_device: handle first time activation of console device

2011-11-16 Thread Rajendra Nayak
console device on OMAP is never reset or idled by hwmod post initial setup, early during boot, for obvious reasons not to break early debug prints thrown on console. This leaves the console device enabled at boot and the first activation of it using hwmod needs to be handled in such a way that a di