Re: [PATCH 1/2] drivers: create a pinmux subsystem v3

2011-08-19 Thread Linus Walleij
On Thu, Jun 16, 2011 at 2:47 PM, Linus Walleij wrote: > So to summarize there are two related areas of discussion > here: > > 1. Whether a pinmux map shall map one or 1..N functions > 2. How to handle per-driver instance namespacing of functions > > In both cases I'm currently using simple string

Re: [PATCH 1/2] drivers: create a pinmux subsystem v3

2011-08-19 Thread Linus Walleij
On Sat, Jul 9, 2011 at 12:23 PM, Mark Brown wrote: > On Mon, Jun 13, 2011 at 01:57:36PM -0600, Grant Likely wrote: >> On Mon, Jun 13, 2011 at 10:58 AM, Linus Walleij >> >> I would *strongly* recommend against individual device drivers >> accessing the pinmux api.  This is system level configuratio

Re: [PATCH 1/2] drivers: create a pinmux subsystem v3

2011-08-19 Thread Linus Walleij
On Thu, Jul 14, 2011 at 7:57 AM, Barry Song <21cn...@gmail.com> wrote: > has this been ready for 3.1? we have been planning to write pinmux > driver based on this framework. On Mon, Aug 8, 2011 at 4:28 AM, Barry Song <21cn...@gmail.com> wrote: > What is the status of pincfg subsystem? what's the

Re: [PATCH 1/2] drivers: create a pinmux subsystem v3

2011-08-07 Thread Barry Song
Hi Linus, >> diff --git a/Documentation/ABI/testing/sysfs-class-pinmux >> b/Documentation/ABI/testing/sysfs-class-pinmux >> new file mode 100644 >> index 000..c2ea843 >> --- /dev/null >> +++ b/Documentation/ABI/testing/sysfs-class-pinmux >> @@ -0,0 +1,11 @@ >> +What: /sys/class/pinmu

Re: [PATCH 1/2] drivers: create a pinmux subsystem v3

2011-07-09 Thread Mark Brown
On Mon, Jun 13, 2011 at 01:57:36PM -0600, Grant Likely wrote: > On Mon, Jun 13, 2011 at 10:58 AM, Linus Walleij > > +This get/enable/disable/put sequence can just as well be handled by bus > > drivers > > +if you don't want each and every driver to handle it and you know the > > +arrangement on y

RE: [PATCH 1/2] drivers: create a pinmux subsystem v3

2011-06-29 Thread Stephen Warren
Linus Walleij wrote at Monday, June 27, 2011 8:35 AM: > On Thu, Jun 16, 2011 at 9:10 PM, Stephen Warren wrote: ... > > Now, we can have multiple entries with the same .map_name: > > > > static struct pinmux_map pmx_mapping[] = { > >       { > >               .dev_name = "tegra-sdhci.0", > >      

Re: [PATCH 1/2] drivers: create a pinmux subsystem v3

2011-06-27 Thread Linus Walleij
On Thu, Jun 16, 2011 at 9:10 PM, Stephen Warren wrote: > Linus Walleij wrote at Thursday, June 16, 2011 6:47 AM: >> NOW I  *think* I get it. >> >> So we're basically talking about the function mapping API here. > > Yes, basically. > > In more detail, I'm talking about making the "functions" expose

RE: [PATCH 1/2] drivers: create a pinmux subsystem v3

2011-06-16 Thread Stephen Warren
Linus Walleij wrote at Thursday, June 16, 2011 6:47 AM: > On Wed, Jun 15, 2011 at 12:11 AM, Stephen Warren wrote: > > [Me] > >> Can't you just send some patch or example .h file for the API > >> you would like to see so I understand how you think about > >> this? > > > > Are your patches in git so

Re: [PATCH 1/2] drivers: create a pinmux subsystem v3

2011-06-16 Thread Linus Walleij
On Wed, Jun 15, 2011 at 12:11 AM, Stephen Warren wrote: > [Me] >> Can't you just send some patch or example .h file for the API >> you would like to see so I understand how you think about >> this? > > Are your patches in git somewhere? It's much easier for me to pull > at present than grab patche

RE: [PATCH 1/2] drivers: create a pinmux subsystem v3

2011-06-15 Thread Stephen Warren
Linus Walleij wrote at Tuesday, June 14, 2011 8:26 AM: > On Tue, Jun 14, 2011 at 1:28 AM, Stephen Warren wrote: > > > I'm a little confused by this version. > > Sorry, I'll try to clarify. > > > In particular: > > > > * I don't see some changes that I thought we'd agreed upon during earlier > >

Re: [PATCH 1/2] drivers: create a pinmux subsystem v3

2011-06-14 Thread Linus Walleij
On Mon, Jun 13, 2011 at 9:57 PM, Grant Likely wrote: > (...) > To sum up, it looks like the conceptual model is thus: > > - A pinmux driver enumerates and registers all the pins that it has > - Setup code and/or driver code requests blocks of pins (functions) > when it needs them > - If all the p

Re: [PATCH 1/2] drivers: create a pinmux subsystem v3

2011-06-14 Thread Linus Walleij
On Tue, Jun 14, 2011 at 1:28 AM, Stephen Warren wrote: > I'm a little confused by this version. Sorry, I'll try to clarify. > In particular: > > * I don't see some changes that I thought we'd agreed upon during earlier > review rounds, such as: > > ** Removing pinmux_ops members list_functions,

Re: [PATCH 1/2] drivers: create a pinmux subsystem v3

2011-06-14 Thread Linus Walleij
Hi Joe, thanks for the review, excellent as always. I fixed all except the below pattern, also searched the source to make sure there were no other cases of the same errors. On Mon, Jun 13, 2011 at 8:11 PM, Joe Perches wrote: >> +int pinctrl_register_pins_dense(struct pinctrl_pin_desc const *p

RE: [PATCH 1/2] drivers: create a pinmux subsystem v3

2011-06-14 Thread Stephen Warren
Linus Walleij wrote at Monday, June 13, 2011 10:58 AM: > This creates a subsystem for handling of pinmux devices. These are > devices that enable and disable groups of pins on primarily PGA and > BGA type of chip packages and common in embedded systems. I'm a little confused by this version. In pa

Re: [PATCH 1/2] drivers: create a pinmux subsystem v3

2011-06-13 Thread Grant Likely
On Mon, Jun 13, 2011 at 10:58 AM, Linus Walleij wrote: > From: Linus Walleij > > This creates a subsystem for handling of pinmux devices. These are > devices that enable and disable groups of pins on primarily PGA and > BGA type of chip packages and common in embedded systems. > > This is being d

Re: [PATCH 1/2] drivers: create a pinmux subsystem v3

2011-06-13 Thread Joe Perches
On Mon, 2011-06-13 at 18:58 +0200, Linus Walleij wrote: > This creates a subsystem for handling of pinmux devices. These are > devices that enable and disable groups of pins on primarily PGA and > BGA type of chip packages and common in embedded systems. Trivia only: > diff --git a/drivers/pinctr

[PATCH 1/2] drivers: create a pinmux subsystem v3

2011-06-13 Thread Linus Walleij
From: Linus Walleij This creates a subsystem for handling of pinmux devices. These are devices that enable and disable groups of pins on primarily PGA and BGA type of chip packages and common in embedded systems. This is being done to depopulate the arch/arm/* directory of such custom drivers an