Re: [Xen-devel] [PATCH 01/24] arm: initial Xen support

2012-08-06 Thread Stefano Stabellini
On Wed, 1 Aug 2012, Konrad Rzeszutek Wilk wrote: > > > > +struct pvclock_wall_clock { > > > > + u32 version; > > > > + u32 sec; > > > > + u32 nsec; > > > > +} __attribute__((__packed__)); > > > > > > That is weird. It is 4+4+4 = 12 bytes? Don't you want it to be 16 bytes? >

Re: [Xen-devel] [PATCH 01/24] arm: initial Xen support

2012-08-06 Thread Stefano Stabellini
On Thu, 2 Aug 2012, Konrad Rzeszutek Wilk wrote: > On Thu, Aug 02, 2012 at 08:35:51AM +0100, Ian Campbell wrote: > > On Wed, 2012-08-01 at 19:27 +0100, Rob Herring wrote: > > > On 07/26/2012 10:33 AM, Stefano Stabellini wrote: > > > > - Basic hypervisor.h and interface.h definitions. > > > > - Skel

Re: [Xen-devel] [PATCH 01/24] arm: initial Xen support

2012-08-02 Thread Konrad Rzeszutek Wilk
On Thu, Aug 02, 2012 at 08:35:51AM +0100, Ian Campbell wrote: > On Wed, 2012-08-01 at 19:27 +0100, Rob Herring wrote: > > On 07/26/2012 10:33 AM, Stefano Stabellini wrote: > > > - Basic hypervisor.h and interface.h definitions. > > > - Skelethon enlighten.c, set xen_start_info to an empty struct. >

Re: [PATCH 01/24] arm: initial Xen support

2012-08-02 Thread Ian Campbell
On Wed, 2012-08-01 at 19:27 +0100, Rob Herring wrote: > On 07/26/2012 10:33 AM, Stefano Stabellini wrote: > > - Basic hypervisor.h and interface.h definitions. > > - Skelethon enlighten.c, set xen_start_info to an empty struct. > > - Do not limit xen_initial_domain to PV guests. > > > > The new co

Re: [PATCH 01/24] arm: initial Xen support

2012-08-01 Thread Rob Herring
On 07/26/2012 10:33 AM, Stefano Stabellini wrote: > - Basic hypervisor.h and interface.h definitions. > - Skelethon enlighten.c, set xen_start_info to an empty struct. > - Do not limit xen_initial_domain to PV guests. > > The new code only compiles when CONFIG_XEN is set, that is going to be > add

Re: [Xen-devel] [PATCH 01/24] arm: initial Xen support

2012-08-01 Thread Konrad Rzeszutek Wilk
> > > +struct pvclock_wall_clock { > > > + u32 version; > > > + u32 sec; > > > + u32 nsec; > > > +} __attribute__((__packed__)); > > > > That is weird. It is 4+4+4 = 12 bytes? Don't you want it to be 16 bytes? > > I agree that 16 bytes would be a better choice, but it needs to match > the s

Re: [Xen-devel] [PATCH 01/24] arm: initial Xen support

2012-07-27 Thread Stefano Stabellini
On Thu, 26 Jul 2012, Konrad Rzeszutek Wilk wrote: > On Thu, Jul 26, 2012 at 04:33:43PM +0100, Stefano Stabellini wrote: > > - Basic hypervisor.h and interface.h definitions. > > - Skelethon enlighten.c, set xen_start_info to an empty struct. > > Skeleton > > > - Do not limit xen_initial_domain to

Re: [Xen-devel] [PATCH 01/24] arm: initial Xen support

2012-07-27 Thread Konrad Rzeszutek Wilk
On Thu, Jul 26, 2012 at 04:33:43PM +0100, Stefano Stabellini wrote: > - Basic hypervisor.h and interface.h definitions. > - Skelethon enlighten.c, set xen_start_info to an empty struct. Skeleton > - Do not limit xen_initial_domain to PV guests. Better wording: Make xen_initial_domain dependent o

[PATCH 01/24] arm: initial Xen support

2012-07-26 Thread Stefano Stabellini
- Basic hypervisor.h and interface.h definitions. - Skelethon enlighten.c, set xen_start_info to an empty struct. - Do not limit xen_initial_domain to PV guests. The new code only compiles when CONFIG_XEN is set, that is going to be added to arch/arm/Kconfig in a later patch. Signed-off-by: Stefa