Re: [PATCH] thermal: Fix for setting the thermal zone mode to enable/disable

2012-03-22 Thread Len Brown
applied. thanks, Len Brown, Intel Open Source Technology Center ___ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev

Re: [PATCH] thermal: Fix for setting the thermal zone mode to enable/disable

2012-03-21 Thread Amit Kachhap
On 21 March 2012 19:43, Jean Delvare wrote: > On Wed, 21 Mar 2012 16:40:01 +0530, Amit Daniel Kachhap wrote: >> Basically without this patch changing the mode of thermal zone >> is not possible as wrong string size is passed to strncmp. > > Actually it is possible, > $ echo -n disabled > mode > wo

Re: [PATCH] thermal: Fix for setting the thermal zone mode to enable/disable

2012-03-21 Thread Geert Uytterhoeven
On Wed, Mar 21, 2012 at 15:13, Jean Delvare wrote: > On Wed, 21 Mar 2012 16:40:01 +0530, Amit Daniel Kachhap wrote: >> Basically without this patch changing the mode of thermal zone >> is not possible as wrong string size is passed to strncmp. > > Actually it is possible, > $ echo -n disabled > mo

Re: [PATCH] thermal: Fix for setting the thermal zone mode to enable/disable

2012-03-21 Thread Jean Delvare
On Wed, 21 Mar 2012 16:14:46 +0100, Geert Uytterhoeven wrote: > On Wed, Mar 21, 2012 at 15:13, Jean Delvare wrote: > > On Wed, 21 Mar 2012 16:40:01 +0530, Amit Daniel Kachhap wrote: > >> Basically without this patch changing the mode of thermal zone > >> is not possible as wrong string size is pas

Re: [PATCH] thermal: Fix for setting the thermal zone mode to enable/disable

2012-03-21 Thread Jean Delvare
Hi Eric, On Wed, 21 Mar 2012 10:47:52 -0400, Eric Paris wrote: > On Wed, Mar 21, 2012 at 10:13 AM, Jean Delvare wrote: > > Note that a quick grep suggests that drivers/misc/ad525x_dpot.c, > > security/selinux/hooks.c and arch/m68k/sun3/prom/console.c suffer from > > the same issue, if you want to

Re: [PATCH] thermal: Fix for setting the thermal zone mode to enable/disable

2012-03-21 Thread Eric Paris
On Wed, Mar 21, 2012 at 10:13 AM, Jean Delvare wrote: > On Wed, 21 Mar 2012 16:40:01 +0530, Amit Daniel Kachhap wrote: >> Basically without this patch changing the mode of thermal zone >> is not possible as wrong string size is passed to strncmp. > > Actually it is possible, > $ echo -n disabled >

Re: [PATCH] thermal: Fix for setting the thermal zone mode to enable/disable

2012-03-21 Thread Jean Delvare
On Wed, 21 Mar 2012 16:40:01 +0530, Amit Daniel Kachhap wrote: > Basically without this patch changing the mode of thermal zone > is not possible as wrong string size is passed to strncmp. Actually it is possible, $ echo -n disabled > mode works fine. But it fails without the -n, your patch would

[PATCH] thermal: Fix for setting the thermal zone mode to enable/disable

2012-03-21 Thread Amit Daniel Kachhap
Basically without this patch changing the mode of thermal zone is not possible as wrong string size is passed to strncmp. Signed-off-by: Amit Daniel Kachhap --- drivers/thermal/thermal_sys.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/thermal_sys.c